[HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Go to the “Assign task”
3. Enter title click on “Confirm task”

Expected Result:

After creating a task without assignee “0” should not be displayed

Actual Result:

After creating a task without assignee “0” displayed after leaving

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-07.at.2.08.21.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688677922284949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128bb3b4ad89ce372
• Upwork Job ID: 1677273013757554688
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

FYI I kicked off the release less than 5 minutes ago and I'm worried the existence of a new deploy blocker will cause issues. I'll re-add it once the new checklist is up!

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating task without assignee, "0" is displayed

What is the root cause of that problem?

Issue happens on this line:

App/src/components/TaskHeader.js

Line 83 in 0ee7dfa

{assigneeAccountID && assigneeAccountID > 0 && (

assigneeAccountID is number and when no assignee, this fallbacks to 0.
And 0 && 0 > 0 && <></> returns 0

What changes do you think we should make in order to solve the problem?

remove this redundant condition: assigneeAccountID &&

Fixed code will look like this:

 {assigneeAccountID > 0 && (

[MariaHCD]

Able to reproduce on dev:

@situchan's proposed solution seems to fix this.

I see that logic was added in #20689 that was deployed 2 weeks ago. Not sure why we're just catching this now.

cc: @hoangzinh @mollfpr @joelbettner

[situchan]

@MariaHCD this bug existed from the beginning but recent PR just revealed this.
I'd say #20689 is not a regression as the bad logic already existed and deployed to production 2 weeks ago.

-                               {props.report.managerID && props.report.managerID > 0 && (
+                               {assigneeAccountID && assigneeAccountID > 0 && (

[MariaHCD]

assigneeAccountID is number and when no assignee, this fallbacks to 0.
And 0 && 0 > 0 && <></> returns 0

Confirmed that getTaskAssigneeAccountID does indeed return 0 if no assignee is set because the managerID in Onyx is 0:

Let's prioritize fixing this and go with @situchan's solution!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128bb3b4ad89ce372

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @ayazhussain79 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[MariaHCD]

Summary: we're going with @situchan's fix as outlined here to fix this deploy blocker. Will need @aimane-chnaif's help to review and test!

[hoangzinh]

I see that logic was added in #20689 that was deployed 2 weeks ago. Not sure why we're just catching this now.

cc: @hoangzinh @mollfpr @joelbettner

@MariaHCD I think the reason why we're just catching this now is from this PR https://github.com/Expensify/App/pull/21781/files#diff-941175f813fc9ba999d5f8221c16657a8f274cc7a803657578d5e4f01ae26da4R650

Before we will return null if childManagerEmail is a falsy value, but with above change, we might return 0.
But I agree with @situchan proposal above #22398 (comment)

[MariaHCD]

Before we will return null if childManagerEmail is a falsy value, but with above change, we might return 0.

Ah, nice catch, @hoangzinh. Thanks for sharing!

[melvin-bot]

🎯 ⚡️ Woah @aimane-chnaif / @situchan, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @situchan got assigned: 2023-07-07 11:07:30 Z
• when the PR got merged: 2023-07-07 12:09:18 UTC

On to the next one 🚀

[Julesssss]

Thanks for the quick fix all, I'm going to check it off the deploy checklist.

[MitchExpensify]

Invites sent to @ayazhussain79 @situchan for eventual payment 👍

[ayazhussain79]

@MitchExpensify Offer accepted, Thank you

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "0" display issue after creating task without assignee #22406

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay out on 7/17 👍

Lets square off the BZ steps above in advance of that @aimane-chnaif 🚀

[MitchExpensify]

Payments issued! Friendly bump on @aimane-chnaif on the BZ steps :)

[MitchExpensify]

friendly bump @aimane-chnaif 👍

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Fix empty assignee in TaskHeader and update permission to mark Task complete/incomplete/cancel in Task report #20689
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20689/files#r1270099447
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need regression test step. It's already in checklist:

• I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.

[MitchExpensify]

Awesome, thank you @aimane-chnaif !