Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-02] Implement bidirectional pagination in ReportActionsList #23223

Closed
roryabraham opened this issue Jul 19, 2023 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jul 19, 2023

HOLD on:

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.tgiglcuu8pr9
Project: Comment Linking

For bidirectional scrolling, we need to enable the addition of new data to the chat from both ends. The top end utilizes built-in methods onEndReachedThreshold and onEndReached. We need to start using onStartReached for the bottom end as well.

We should call the GetOlderActions API onEndReached and GetNewerActions API onStartReached.

Also, this PR should enable the CheckForPreviousReportActionID migration being built here.

Manual Test Steps

TBD

Automated Tests

TBD

Issue OwnerCurrent Issue Owner: @sonialiap
@roryabraham roryabraham added Engineering Weekly KSv2 NewFeature Something to build that is a new item. labels Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

@roryabraham
Copy link
Contributor Author

cc @perunt

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@perunt
Copy link
Contributor

perunt commented Jul 20, 2023

Here we go! 🚀

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 21, 2023
@roryabraham roryabraham changed the title [HOLD] Implement bidirectional pagination in ReportActionsList Implement bidirectional pagination in ReportActionsList Aug 29, 2023
@roryabraham roryabraham added Daily KSv2 and removed Monthly KSv2 labels Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

@perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@perunt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@perunt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2023

@perunt 10 days overdue. Is anyone even seeing these? Hello?

@perunt
Copy link
Contributor

perunt commented Sep 13, 2023

It's not overdue, the PR is ready and waiting for another perf improvements PRs to be merged.

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@perunt Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 26, 2023
@melvin-bot melvin-bot bot changed the title Implement bidirectional pagination in ReportActionsList [HOLD for payment 2023-11-02] Implement bidirectional pagination in ReportActionsList Oct 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @perunt does not require payment (Contractor)

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@perunt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 2, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

@perunt Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2023
@roryabraham
Copy link
Contributor Author

Assigning new feature and @s77rt for C+ payment

@roryabraham
Copy link
Contributor Author

@sonialiap can you please issue C+ review payment to @s77rt then close this out?

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@sonialiap
Copy link
Contributor

@s77rt offer sent

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@webmaster1022
Copy link

Hi, How are you?
May I work with this issue?
Thanks!

Copy link

melvin-bot bot commented Nov 13, 2023

📣 @webmaster1022! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@sonialiap
Copy link
Contributor

@webmaster1022 this issue has been resolved. Please check out the Open issues with the Help Wanted label for issues available to be worked on.

@s77rt
Copy link
Contributor

s77rt commented Nov 13, 2023

@sonialiap Accepted! Please make sure the payment is $125 (for two regressions: #30423 and #30729). Thanks!

@sonialiap
Copy link
Contributor

Thanks @s77rt , payment of $125 sent ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

6 participants