[HOLD for payment 2023-08-28] [$1000] ReportPreview has replies, but there's no option to reply in thread when hovering.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account.
2. Try to request money to any account.
3. Hover on the money request.
4. Notice that, it showed 1 reply but there's no option to reply in thread.

Expected Result:

There should be option to reply in thread when hovering or right click on money request.

Actual Result:

There's no action to reply in thread when hovering or right click on money request.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5552.mp4

Screen.Recording.2023-07-17.at.22.06.44.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689606579815989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011c9047e249918424
• Upwork Job ID: 1684138930178179072
• Last Price Increase: 2023-08-09
• Automatic offers:
• situchan | Contributor | 26006189
• hungvu193 | Reporter | 26006191

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @hungvu193

Please re-state the problem that we are trying to solve in this issue.

ReportPreview has replies, but there's no option to reply in thread when hovering.

What is the root cause of that problem?

We're checking here to show reply in thread option, we only showed "reply in thread" when our reportActions have type "ADDCOMMENT", but since we introduced report preview action and IOU which also had replies, we didn't add it in here yet.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 121 in 7770b86

type === CONTEXT_MENU_TYPES.REPORT_ACTION && reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID),

What changes do you think we should make in order to solve the problem?

We should also include REPORTPREVIEW and IOU type in our shouldShow condition in here:

                    type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
                    ((reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID)) ||
                        reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW ||
                        reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU)

Alternatively, we can replace reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW) with ReportActionUtils.isReportPreviewAction(reportAction)

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

@CortneyOfstad I'm OoO on Monday and Tuesday, so co-assigning this in case you can get to it before Wednesday!

[melvin-bot]

@conorpendergrast Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[conorpendergrast]

My bad, sorry, I unassigned the wrong account here. Reproduced, all done:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011c9047e249918424

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[conorpendergrast]

@0xmiroslav There's a proposal from @hungvu193 to review above, fyi

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[conorpendergrast]

Nice, looks like the PR is making progress and just got sent to Jules for review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hungvu193 got assigned: 2023-08-08 09:53:25 Z
• when the PR got merged: 2023-08-16 15:20:50 UTC
• days elapsed: 6

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show reply in thread for IOU and Task. #24412

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment offer (Reporter)
• @situchan requires payment offer (Contributor+)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[conorpendergrast]

From reading #25688, this issue (#23377) wasn't the cause of the deploy blocker. So we are good to pay here, without urgency bonus

[situchan]

I think Melvin miscalculated timeline.
@hungvu193 was assigned on Aug 11 8:29 AM
PR was C+ approved on Aug 16 7:13 AM
PR was merged without further changes on Aug 16 3:13 PM
Aug 12, 13 was weekend

There was internal discussion that bonus still applies if no changes requested after C+ approval before merge.
#15486 (comment)
cc: @mallenexpensify

[conorpendergrast]

@situchan That looks like more than 72 hours, when you exclude weekends. Can you share your maths for the timeline being less than 72 hours between assign and merge?

[conorpendergrast]

Payouts due:

• Issue Reporter: $250 @hungvu193
• Contributor: $1000 @hungvu193 - paid via bonus in https://www.upwork.com/nx/wm/workroom/34455224/overview, FYI
• Contributor+: $1000 @situchan

Eligible for 50% #urgency bonus? NO

Upwork job is here.

[conorpendergrast]

Still have the C+ checklist too please!

[situchan]

I updated comment - #23377 (comment) regarding timeline

[situchan]

No PR caused regression. This case was missed during initial implementation of ReportPreview and MoneyRequestPreview.

Regression Test Proposal:

1. Go to any DM chat
2. Request money
3. In IOU report, hover on MoneyRequestPreview
4. Verify that "Reply in thread" icon shows in mini context menu
5. Go back to DM chat
6. Hover on ReportPreview
7. Verify that "Reply in thread" icon shows in mini context menu

[conorpendergrast]

@situchan In that example above, the Contributor created the PR around 9 hours after they were assigned to the issue, and the C+ 36 hours later. Then the engineer led discussed that didn't end up changing the PR for four days. I don't think that's the equivalent to here, when the engineer reviewed and merged the PR 8 hours after you approved it.

I'm sticking with no urgency bonus as a result

[conorpendergrast]

Thanks for the checklist too - I'm closing this out!