Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-23] Payment issue for E/App PR#21551 #24317

Closed
melvin-bot bot opened this issue Aug 9, 2023 · 14 comments
Closed

[HOLD for payment 2023-08-23] Payment issue for E/App PR#21551 #24317

melvin-bot bot opened this issue Aug 9, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Issue created to compensate the Contributor+ member for their work on #21551
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @allroundexperts.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011a68a4bc16656fb2
  • Upwork Job ID: 1689282613716099072
  • Last Price Increase: 2023-08-09
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 9, 2023
@melvin-bot melvin-bot bot mentioned this issue Aug 9, 2023
57 tasks
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011a68a4bc16656fb2

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 9, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 9, 2023

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Aug 11, 2023
@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Aug 15, 2023
@puneetlath
Copy link
Contributor

Setting to weekly since this isn't on prod yet.

@puneetlath puneetlath changed the title Payment issue for E/App PR#21551 [HOLD for payment 2023-08-23] Payment issue for E/App PR#21551 Aug 21, 2023
@puneetlath
Copy link
Contributor

puneetlath commented Aug 22, 2023

Payment summary:

@allroundexperts please go ahead and request via NewDot and ping me here when you have.

@allroundexperts
Copy link
Contributor

This might potentially have a regression (#16805) so I want to wait for things to finalize.

@puneetlath
Copy link
Contributor

@allroundexperts did that end up being a regression of this PR?

@allroundexperts
Copy link
Contributor

Yep. Seems like there was a regression. I'll request half the original amount. Can you please update the payment summary?

@puneetlath

This comment was marked as outdated.

@allroundexperts
Copy link
Contributor

Requested @puneetlath!

@allroundexperts
Copy link
Contributor

Actually according to @Julesssss comment, this did not cause any regression. So this should be eligible for full payment. @puneetlath Apologies for the inconvenience.

@puneetlath
Copy link
Contributor

Ok, ignore my latest comment then.

@JmillsExpensify this is the proper payment summary.

@JmillsExpensify
Copy link

Reviewed the details for @allroundexperts. $1,000 approved for payment based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants