Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments - User can not scroll the PDF by using the down/up arrow in Keyboard #24326

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 9, 2023 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to staging.new.expensify.com
  2. On a conversation, click on the + button in the compose box
  3. Upload a PDF
  4. Verify you can scroll the PDF by using the up/down arrow in Keyboard

Expected Result:

User should be able to scroll through PDF file using the keyboard arrow

Actual Result:

Up/down keyboard arrows does not response when try to scroll to PDF

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159057_Recording__646.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 9, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2023

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Aug 9, 2023
@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 9, 2023

Guys, as I commented above this is a regression from #22760 where I am an author of changes. So, it should be self-assigning.

@situchan
Copy link
Contributor

situchan commented Aug 9, 2023

This is not open for proposals everyone.
The offending PR author (@rezkiy37) and reviewer (me) will be taking this.

@jasperhuangg
Copy link
Contributor

Thanks @situchan, be sure to tag this issue in the PR fixing it!

@situchan
Copy link
Contributor

situchan commented Aug 9, 2023

@puneetlath
Copy link
Contributor

@jasperhuangg I can take this over since it's related to an issue I was CME for.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 10, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 10, 2023
@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Aug 11, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

This issue has not been updated in over 15 days. @puneetlath eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@puneetlath
Copy link
Contributor

Looks like this was deployed to production quite a while ago. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants