-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-06] [$1000] Workspace - Highlight on text is displayed when email is pressed in Bills screen #24591
Comments
ProposalPlease re-state the problem that we are trying to solve in this issue.Highlight on text is displayed when email is pressed in Bills screen What is the root cause of that problem?The root cause of the issue is that the container for What changes do you think we should make in order to solve the problem?We need to add the following here:
We need to add the above for iOS only, although adding it for all platforms wouldn't really cause any error. We're already doing this here. If that is not an option, then, I think a cleaner way to add this on iOS only would be to create a platform specific What alternative solutions did you explore? (Optional)None |
Triggered auto assignment to @joekaufmanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
@joekaufmanexpensify I think the test steps should be updated because this is only reproducible once you are logged in with a non-public domain email account ie |
I'm unable to reproduce this at all on iOS (in either an expensifail account, or in a public domain account). |
@allroundexperts could you please share what you're seeing in a public domain account? |
Here's what it looks like with a public domain account: https://github.com/Expensify/App/assets/30054992/5cb636e6-a6fb-45cf-aebe-55f89f84737a |
I don't think that is a bug. There is nothing to select there purposefully as public domain emails do not have a bill intake email address to send in bills (as they don't have a private domain). |
Sorry, this happens when you're NOT on a public domain email. |
Got it, thanks for clarifying that! |
@joekaufmanexpensify Try holding the press. |
You mean long pressing on the bill intake email address? If so, doing that highlights the email (as long as I am long pressing). But does not result in the check mark appearing. Which feels like expected behavior IMO. |
It should not highlight the Pressables on native platforms. Like this is the bug. For reference, go to any chat that contains a link and try long pressing on it. You won't really see the highlight. Same is the case when you long press the green |
Ref: Screen.Recording.2023-08-16.at.2.30.01.AM.movScreen.Recording.2023-08-16.at.2.32.49.AM.mov |
Here's how this looks on web. Notice that there is no highlight. Screen.Recording.2023-08-18.at.3.00.50.AM.mov |
Cool cool, yeah I just tested this on mobile web on iOS and web, and confirmed the there is no highlight when long tapping/clicking on the email. It just selects the email (and we show that via the copy checkmark), once you let go of the long tap/click. |
Job added to Upwork: https://www.upwork.com/jobs/~01b7076c95fa743b6d |
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($1000) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@mollfpr / @allroundexperts mind completing the BZ checklist here so we can prep to issue payment next week? |
@allroundexperts was assigned to this issue on 2023-08-24, and the PR was merged on 2023-08-25, so this qualifies for a speed bonus. This means we need to issue the following payments:
|
Sorry for the delay @joekaufmanexpensify
https://github.com/Expensify/App/pull/19391/files#r1316716014
The regression step should be enough.
|
This is a pretty minor bug that doesn't impact the user experience, so my 2c is no regression test is needed here. |
BZ checklist all set! |
@mollfpr $1,500 sent and contract ended! |
@allroundexperts could you please request $1,500 in NewDot and confirm here once complete? |
Requested! |
Great, thanks! Going to close this out for now. If your request isn't paid within the next 7 days, LMK and I will look into it. |
Note for the individual paying, that the payment summary message is here. |
$1,500 approved for payment via NewDot based on BZ summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #24244
Action Performed:
Expected Result:
No highlight on text when email is pressed
Actual Result:
Highlight is displayed when email is pressed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.54.5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6165815_24244_iOS.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: