Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-26] [TS migration] Migrate 'Policy.js' lib to TypeScript #24918

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 21 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/Policy.js 16
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@blazejkustra
Copy link
Contributor

@BartoszGrajdek No longer blocked, you can start working on it.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 27, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 27, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@fabioh8010
Copy link
Contributor

Hey @BartoszGrajdek are you still planning to work on this one?

@BartoszGrajdek
Copy link
Contributor

Hi @fabioh8010 yes, I have most of it done - I have a task with higher priority right now though, so I'll come back to this issue tomorrow

@cdOut
Copy link
Contributor

cdOut commented Dec 14, 2023

Hey! I’m Tymoteusz from Software Mansion, an expert agency, and I will taking over this task from Bartek.

@roryabraham roryabraham assigned cdOut and unassigned BartoszGrajdek Dec 15, 2023
@melvin-bot melvin-bot bot removed the Overdue label Dec 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
@roryabraham
Copy link
Contributor

Pinged in slack for an update: https://expensify.slack.com/archives/C0593T50UHG/p1703715108039269

@cdOut
Copy link
Contributor

cdOut commented Dec 28, 2023

Pinged in slack for an update: https://expensify.slack.com/archives/C0593T50UHG/p1703715108039269

As an update, I created a draft PR for this issue.

@roryabraham
Copy link
Contributor

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@roryabraham
Copy link
Contributor

Looks like early reviews and development are ongoing in the PR: #33691

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Jan 9, 2024
@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 17, 2024
Copy link
Author

melvin-bot bot commented Jan 17, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 19, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Policy.js' lib to TypeScript [HOLD for payment 2024-01-26] [TS migration] Migrate 'Policy.js' lib to TypeScript Jan 19, 2024
Copy link
Author

melvin-bot bot commented Jan 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 19, 2024
Copy link
Author

melvin-bot bot commented Jan 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-26. 🎊

For reference, here are some details about the assignees on this issue:

  • @cdOut does not require payment (Contractor)

Copy link
Author

melvin-bot bot commented Jan 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@cdOut] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@trjExpensify
Copy link
Contributor

👋 confirming the $250 payment for this is to @alitoshmatov for the C+ review of the PR, right?

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@trjExpensify
Copy link
Contributor

Offer sent!

@alitoshmatov
Copy link
Contributor

Accepted

@trjExpensify
Copy link
Contributor

paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

7 participants