Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] Allow deep null values on merge operations #381

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

@fabioh8010 fabioh8010 requested a review from a team as a code owner October 2, 2023 10:47
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team October 2, 2023 10:47
@MonilBhavsar
Copy link
Contributor

I could not find the reason why it was reverted before and what we have done to prevent that. Could you please share some context

@fabioh8010
Copy link
Contributor Author

@MonilBhavsar This PR was reverted because of this. We took the opportunity of that PR to fix some typings on Onyx related to null values, but as it got reverted we decided to create a separate one with just the fix on the types.

Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me 👍

@MonilBhavsar MonilBhavsar merged commit 579b686 into Expensify:main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants