Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [$250] [TS migration] Migrate 'UserDetailsTooltip' component to TypeScript #25106

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 28 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/UserDetailsTooltip/userDetailsTooltipPropTypes.js 3
src/components/UserDetailsTooltip/index.web.js 15
src/components/UserDetailsTooltip/index.js 1
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 12, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@robertjchen
Copy link
Contributor

Thanks!!

@getusha
Copy link
Contributor

getusha commented Dec 19, 2023

@robertjchen could you please assign me add the BUG label for C+ payment?

@robertjchen robertjchen added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 19, 2023
Copy link
Author

melvin-bot bot commented Dec 19, 2023

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 19, 2023
Copy link
Author

melvin-bot bot commented Dec 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link
Author

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter - N/A
  • Contributor that fixed the issue - N/A - Contractor
  • Contributor+ that helped on the issue and/or PR - @getusha - $500 via Upwork

For reference, here are some details about the assignees on this issue:

  • @blazejkustra does not require payment (Contractor)
  • @getusha requires payment (Needs manual offer from BZ)

Copy link
Author

melvin-bot bot commented Dec 21, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@getusha] Determine if we should create a regression test for this bug.
  • [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@strepanier03
Copy link
Contributor

@getusha - I have hired you for the job in Upwork. I am online tomorrow and for the rest of the day, but then offline until the 3rd. Please accept the contract when you can.


If the checklist here doesn't apply to your work, please leave a comment stating that and providing a reason why, then @ mention me. Otherwise, I'll check here periodically today and tomorrow for the checklist responses so I can pay you and move this forward.

@getusha
Copy link
Contributor

getusha commented Dec 28, 2023

@strepanier03 the PR was reverted so we should handle the payment after the new PR is merged.

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@robertjchen, @strepanier03, @blazejkustra, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link
Author

melvin-bot bot commented Jan 1, 2024

@robertjchen, @strepanier03, @blazejkustra, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@blazejkustra
Copy link
Contributor

@robertjchen PR is ready for final review & merge 👍

@strepanier03
Copy link
Contributor

The PR is now merged but not deployed. I'll wait for the deploy then pay it out.

@strepanier03
Copy link
Contributor

Deployed to staging, will confirm deploy to prod and finish up.

@strepanier03
Copy link
Contributor

Still on staging.

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@robertjchen robertjchen added the Reviewing Has a PR in review label Jan 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@strepanier03
Copy link
Contributor

Will check tomorrow, still on staging as of now.

@strepanier03
Copy link
Contributor

All right, this is deployed to Prod now.

@strepanier03
Copy link
Contributor

@getusha - Do we need to do the checklist here and a reg test or does this not apply?

If the checklist doesn't apply, let me know and I'll handle payment. Since this is TS, the payment should be $250 so I'll make sure to update the job before paying if it's not already set that way.

@getusha
Copy link
Contributor

getusha commented Jan 10, 2024

@strepanier03 The checklist doesn't apply here since it is a migration issue and not a bug.

@strepanier03
Copy link
Contributor

Great, thanks for confirming @getusha. I'm finishing up now!

@strepanier03 strepanier03 changed the title [HOLD for payment 2023-12-28] [TS migration] Migrate 'UserDetailsTooltip' component to TypeScript [PAID] [$250] [TS migration] Migrate 'UserDetailsTooltip' component to TypeScript Jan 10, 2024

This comment was marked as outdated.

@strepanier03
Copy link
Contributor

All right, paid up and closed contract.

@strepanier03
Copy link
Contributor

Thanks again everyone!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

5 participants