Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-26] [TS migration] Migrate 'Onfido' component to TypeScript #25136

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/Onfido/onfidoPropTypes.js 1
src/components/Onfido/index.website.js 4
src/components/Onfido/index.native.js 10
src/components/Onfido/index.desktop.js 2
src/components/Onfido/BaseOnfidoWeb.js 13
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Feb 27, 2024
Copy link
Author

melvin-bot bot commented Mar 14, 2024

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 15, 2024
Copy link
Author

melvin-bot bot commented Mar 15, 2024

@Christinadobrzyn
Copy link
Contributor

I think we're waiting for the PR to merge into production still... #31378

@parasharrajat
Copy link
Member

I was C+ on the PR #31378 (comment)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 19, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Onfido' component to TypeScript [HOLD for payment 2024-03-26] [TS migration] Migrate 'Onfido' component to TypeScript Mar 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 19, 2024
Copy link
Author

melvin-bot bot commented Mar 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@VickyStash] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Mar 25, 2024

after 3/26 - assuming no regressions, I think we can close this since @VickyStash is with Callstack and will be paid outside of this BZ.

No regression test for TS migrations - unless you feel there should be for this one @VickyStash

@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Mar 25, 2024
@parasharrajat
Copy link
Member

@Christinadobrzyn I was C+ on this as well.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Mar 26, 2024

Ah thanks for confirming @parasharrajat! I can't remember, are you paid through NewDot?

Payouts due:

Contributor+: $250 @parasharrajat (In New Expensify)

@parasharrajat
Copy link
Member

@Christinadobrzyn Yes, I am paid via NewDot. I will request it later. Please feel free to close this issue. Thanks.

@Christinadobrzyn
Copy link
Contributor

Sounds good! Closing since it's the 26th!

@parasharrajat
Copy link
Member

Payment requested as per #25136 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants