[HOLD for payment 2023-09-18] [$1000] Desktop - Drag & drop container does not add opacity to entire height of the drawer

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the money request page
2. Select Scan tab
3. Drag file to this tab
4. Notice the green opacity does not cover entire height of drawer

Expected Result:

Green opacity should cover entire height of drawer same as desktop

Actual Result:

Green opacity does not cover entire height of drawer and add space on top

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Uploading Recording #250.mp4…

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691787401646299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a2b5135808f4dd46
• Upwork Job ID: 1696559205510832128
• Last Price Increase: 2023-08-29
• Automatic offers:
• tienifr | Contributor | 26516154
• dhairyasenjaliya | Reporter | 26516155

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Drag & drop container does not add opacity to entire height of the drawer

What is the root cause of that problem?

All page is wrapped by ScreenWrapper, in this component we have HeaderGap

App/src/components/ScreenWrapper/index.js

Line 127 in 9a0dd42

<HeaderGap />

On Desktop, we set the height of this component is 12px, and this component style is not affected by dragging action

What changes do you think we should make in order to solve the problem?

Add new headerGapStyles props in ScreenWrapper, and pass it to HeaderGap

    <HeaderGap styles={this.props.headerGapStyles}/>

we also need to update HeaderGap/index.destop.js to support new props

In MoneyRequestSelectorPage, we can detect isDraggingOver then use this value to update headerGapStyles

        <ScreenWrapper
            includeSafeAreaPaddingBottom={false}
            shouldEnableKeyboardAvoidingView={false}
            headerGapStyles={isDraggingOver?[{
                backgroundColor: themeColors.receiptDropUIBG
            }]:[]}
        >

Result

Screen.Recording.2023-08-23.at.18.47.20.mov

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[muttmuure]

I consider this design polish

[muttmuure]

The solution seems pretty good though, so I will add external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a2b5135808f4dd46

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[muttmuure]

Just waiting for @sobitneupane to review #25709 (comment)

[muttmuure]

Just waiting on review

[tienifr]

@sobitneupane Can you help review my proposal? Thanks

[sobitneupane]

Proposal from @tienifr looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@AndrewGable @sobitneupane @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

🎯 ⚡️ Woah @sobitneupane / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-09-05 22:38:34 Z
• when the PR got merged: 2023-09-08 16:52:02 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 25709 drop container does not add opacity to entire height of the drawer #26849

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)
• @dhairyasenjaliya requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[muttmuure]

@sobitneupane - $1500
@tienifr - $1500
@dhairyasenjaliya - $250

[muttmuure]

@tienifr and @dhairyasenjaliya have been paid in Upwork. NewDot payment waiting for @sobitneupane

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#23046

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#23046 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is an edge case missed while adding a new functiolity.

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sobitneupane]

Regression Test Proposal

1. Go to the money request page
2. Select Scan tab
3. Drag file to this tab
4. Verify that the green opacity covers entire height of drawer

[sobitneupane]

Requested payment on newDot.

#25709 (comment)

[JmillsExpensify]

$1,500 payment approved for @sobitneupane based on BZ summary.

[melvin-bot]

@AndrewGable, @sobitneupane, @muttmuure, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!