[HOLD for payment 2023-09-06] [$500] Web - IOU - Opening The cash amount page for the first time display the main chat header briefly

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat and request money
2. Open the IOU report room
3. Now open the cash amount page for the request in the first step

Expected Result:

The main chat header shouldn't appear in the cash amount page

Actual Result:

Opening The cash amount page for the first time display the main chat header briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.57-5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.27-08-23.02_32_13.webm

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692982304284909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a33c6eac44f5e9b0
• Upwork Job ID: 1696203362140925952
• Last Price Increase: 2023-08-28
• Automatic offers:
• alitoshmatov | Contributor | 26373113
• Ahmed-Abdella | Reporter | 26373116

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ahmed-Abdella]

@jliexpensify I can reproduce this only on dev, may be a deploy blocker

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - IOU - Opening The cash amount page for the first time display the main chat header briefly

What is the root cause of that problem?

When optimistic thread report is created for transaction action, it is lacking parentReportID which is used to determine if report is money request action. This is because ReportUtils.buildTransactionThread function is receiving action object which does not have reportID(this is because by report action item does not have reportID field in Onyx, but rather is nested inside reportActions_${reportID}).

App/src/components/ReportActionItem/MoneyRequestAction.js

Line 103 in 0b1cb95

const thread = ReportUtils.buildTransactionThread(action);

But this function is trying to access reportID to set parentReportID of newly build report.

App/src/libs/ReportUtils.js

Line 2519 in d734365

reportAction.reportID,

Thus resulting in optimistic report which does not have parentReportID and this report is treated as normal report and showing chat header.

What changes do you think we should make in order to solve the problem?

We can modify buildTransactionThread to accept reportID as second argument, and pass it when we use the function.
const thread = ReportUtils.buildTransactionThread(action, chatReportID);
Also apply this changes here too:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 287 in 6c8292c

const thread = ReportUtils.buildTransactionThread(reportAction);

What alternative solutions did you explore? (Optional)

Also we can modify here to inject reportID field and value to each report action item making it available for further uses

App/src/pages/home/ReportScreen.js

Line 403 in c16a75b

selector: ReportActionsUtils.getSortedReportActionsForDisplay,

[alitoshmatov]

I think this is regression of #25429 since the issue caused by introduction of ReportUtils.buildTransactionThread function

[jliexpensify]

Thanks @alitoshmatov and @Ahmed-Abdella - I've assigned @rushatgabhane and @grgia to look into this one!

[grgia]

since the issue caused by introduction of ReportUtils.buildTransactionThread function

@mountiny since you worked on this function, would you want to look into this regression?

[mountiny]

@alitoshmatov Thanks! I think your solution makes sense, are you able to work on it now?

[alitoshmatov]

@mountiny Yes, of course.

[mountiny]

@alitoshmatov can you please raise a PR.

can you please use this format

const thread = ReportUtils.buildTransactionThread(action, moneyRequestReportID);

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a33c6eac44f5e9b0

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $500

[mountiny]

Making this $500 given its straightforward

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Modified buildTransactionThread function to accept requestReportID #26118

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @alitoshmatov requires payment offer (Contributor)
• @Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Hmm yes, technically @ayazhussain79 you submitted a bug report 1 day before @Ahmed-Abdella . I would assume that we would pay you as the reporter instead, but let me check.

Asking internally - https://expensify.slack.com/archives/C01SKUP7QR0/p1693363011597719

[jliexpensify]

Ok, here's a payment summary:

• Bug reporter: @ayazhussain79 $250
• Contributor: @alitoshmatov $500 + $250 bonus
• C+: @rushatgabhane $500 + $250 bonus (request in New.Dot)

Upwork job

@Ahmed-Abdella - unfortunately, since @ayazhussain79 reported this bug first, we'll need to pay him. Sorry!

[Ahmed-Abdella]

@jliexpensify No worries 👍

[ayazhussain79]

@jliexpensify Thank you

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Modified buildTransactionThread function to accept requestReportID #26118

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @alitoshmatov requires payment offer (Contributor)
• @ayazhussain79 requires payment (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

@jliexpensify coming from this comment, I updated the OP to reflect the first Slack report of this bug. This means that the bug report bonus should go to @ayazhussain79 (sorry @Ahmed-Abdella!). Do we also need to update the Upwork offer?

[Ahmed-Abdella]

@jliexpensify canceled my offer and @ayazhussain79 got it. Everything is done
@luacmartins

[jliexpensify]

Yep, we are good to go here on the 6th!

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Add edit request button to the report action context menu #25429

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25429/files#r1316327376

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. Part of checklist

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[jliexpensify]

Sweet, payment summary here for J.Mills

[jliexpensify]

Paid Alisher, @ayazhussain79 please accept the invite and I can sort you out. Cheers!

[ayazhussain79]

@jliexpensify Offer accepted. Thank you!

[jliexpensify]

Everyone paid, job closed!

[JmillsExpensify]

$750 payment approved for @rushatgabhane based on BZ summary.