[HOLD for payment 2023-10-05] [$500] Bank account - Bank account message redirects to an invalid page on browser

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26699

Action Performed:

1. Launch New Expensify app
2. Go to Settings > Workspace > any workspace > Bank account
3. Click on the sentence 'Note: To connect with Chase, Wells Fargo, Capital One or Bank of America, please click here to complete this process in a browser'

Expected Result:

User is redirected to bank account page

Actual Result:

User is redirected to an invalid page - https://staging.new.expensify.com/bank-account/new?policyID=

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6196146_20230911_191045.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bb82aa82cce4919
• Upwork Job ID: 1701314698827501568
• Last Price Increase: 2023-09-11
• Automatic offers:
• abdel-h66 | Contributor | 26664619

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The clickable link from the bank account message on desktop redirects to an invalid page on browser

What is the root cause of that problem?

When the link from desktop is clicked it redirect to https://new.expensify.com/bank-account/ on the browser which in turn redirects to https://new.expensify.com/bank-account/new?policyID= with an empty Policy ID and then shows the not found page.

However, when accessing that same link using the Bank Account button on the workspace, it takes the user to the following link https://new.expensify.com/bank-account/new?policyID=EAC61C74BF6E0ACC&backTo=%2Fworkspace%2FEAC61C74BF6E0ACC with the correct policyID and also the backTo parameter.

What changes do you think we should make in order to solve the problem?

The component handling the link click is called BankAccountStep

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 62 in 544661b

function BankAccountStep(props) {

We can pass a new prop called policyID and then use a utility function that exists already to generate a correct link
as follows

const bankAccountRoute = '${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.getBankAccountRoute('new', props.policyID, props.policyID)}';

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bb82aa82cce4919

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Bank account message redirects to an invalid page on browser

What is the root cause of that problem?

we're getting the bankAccountRoute = /bank-account

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 69 in 52c54f4

const bankAccountRoute = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.BANK_ACCOUNT}`;

Then we're navigating to /bank-account/new?policyID=

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 177 in 52c54f4

Navigation.navigate(ROUTES.getBankAccountRoute(this.getRouteForCurrentStep(currentStep), policyId, backTo));

What changes do you think we should make in order to solve the problem?

Firstly, we need to change this line

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 69 in 52c54f4

const bankAccountRoute = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.BANK_ACCOUNT}`;

to

const bankAccountRoute = '${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.getBankAccountRoute('new', props.policyID)}';

Secondly, get the default policyID (can be the first one) if we can't get the policyID from route to prevent the Hmm... it's not here when users go to /bank-account from deeplink

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 176 in 52c54f4

const policyId = lodashGet(this.props.route.params, 'policyID');

        const policyId = lodashGet(this.props.route.params, 'policyID', PolicyUtils.getFirstPolicy())

[mananjadhav]

@abdel-h66's proposal here is good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[pecanoro]

Sounds good! Assigning the proposal!

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @abdel-h66 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdel-h66]

It's ready for review :)

[mananjadhav]

PR review done.

[abdel-h66]

I am blocked if somoeone could help me with the a recording from iOS and Android would be much appreciates, I'm having trouble setting those up on my machine.

The PR doesn't really affect both of these devices but just in case.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @abdel-h66 got assigned: 2023-09-14 01:44:42 Z
• when the PR got merged: 2023-09-25 03:51:20 UTC
• days elapsed: 7

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix:Bank account clickable link redirect to invalid page #27298

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @abdel-h66 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

@mananjadhav bump on BZ checklist ^^

[NicMendonca]

• reporter: n/a
• contributor: @abdel-h66: $500
• c+: @mananjadhav: $500

@abdel-h66 you've been paid via Upwork 🎉
@mananjadhav don't forget to request payment via Expensify 🙇‍♀️

[mananjadhav]

Thanks for the bump @NicMendonca. I don't think we have an offending PR for this one. We didn't originally intend for the feature to work that way (you can correct me if I am wrong).

Neither we need a regression test here, this only applies to the desktop app.

[NicMendonca]

ok! then we're all set here - @mananjadhav don't forget tor request payment via Expensify

Payment summary:

reporter: n/a
contributor: @abdel-h66: $500
c+: @mananjadhav: $500

[JmillsExpensify]

$500 payment approved for @mananjadhav based on BZ summary.