[HOLD for payment 2023-10-09] [$500] Profile pic gets removed in offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to Settings >Profile
2. change profile pic
3. go to offline and wait for few seconds for the profile pic to disappear
4. check the profile pic which does not have default avatar

Expected Result:

should show profile pic

Actual Result:

does not show profile pic

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.68-12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-06.at.2.14.14.PM.mov

Recording.1580.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693284584253529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016669b07ea66a41c4
• Upwork Job ID: 1702222829517451264
• Last Price Increase: 2023-09-14
• Automatic offers:
• tienifr | Contributor | 26747630
• gadhiyamanan | Reporter | 26747631

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jscardona12]

Couldn't replicate on dev

[hungvu193]

Disable cache is enabled, so it's not a bug.

[gadhiyamanan]

@hungvu193 disable cache is not enabled in kavi's video

[hungvu193]

@hungvu193 disable cache is not enabled in kavi's video

Can you reproduce without disable cache enable?

[bernhardoj]

I can reproduce it. The issue will happen if the change avatar request is done (almost) at the same time as you turn off the internet connection. When the request is done, BE will give us a link to the avatar, but because we are offline and the image is not loaded yet, the fallback avatar is shown.

Before the request is done, we are using a local source to show the avatar

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016669b07ea66a41c4

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It does not show profile pic when the user uploads avatar then immediately turn on Offline mode.

What is the root cause of that problem?

As correctly highlighted by @bernhardoj here, this is because the Update Avatar API request is successful and we have the new source, however the Offline mode is turned on before that new source finish loading. So it's currently showing the gray icon as the fallback.

What changes do you think we should make in order to solve the problem?

In here, we should set the fallbackSource as the file.uri as well. Then we pass the fallbackSource to the Avatar when we display it. If the source fails to load, and we have fallbackSource available, we'll display the fallbackSource rather than the gray icon.

This will make sure if the primary source of the avatar returned by BE fails to be loaded in offline mode, we'll show the local image that we already have available, rather than the gray one which is confusing to the user.

What alternative solutions did you explore? (Optional)

NA

[laurenreidexpensify]

@eVoloshchak what you think about proposal above?

[laurenreidexpensify]

bump @eVoloshchak

[eVoloshchak]

Was able to reproduce this, thanks @bernhardoj for the more accurate steps

@tienifr's proposal looks good to me
It's kind of an edge case and is hard to reproduce, but still worth fixing I think

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

Agree let's fix this, assigning you to the issue @tienifr!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-09-19 05:56:31 Z
• when the PR got merged: 2023-09-26 05:37:40 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 27252 Profile pic gets removed in offline mode #27757

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

payment summary:

• External issue reporter - @gadhiyamanan - $50, offer needs to be accepted in Upwork
• Contributor that fixed the issue - @tienifr - $500, payment issued in Upwork
• Contributor+ that helped on the issue and/or PR - @eVoloshchak - $500 please request payment in newdot

[laurenreidexpensify]

@eVoloshchak please advise on steps above ^^

[gadhiyamanan]

@laurenreidexpensify offer accepted
this is eligible for $250 because it was reported before 30 august

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this is an edge case that is reproducible if lose connection at a specific time (after the image was uploaded, but before it can be downloaded from BE by the App)
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is an extreme edge case and we already have an item in the reviewer checklist to test for offline scenarios
• Determine if we should create a regression test for this bug.
  This is an edge case that a few users would have ever encountered, so I don't think regression test is needed here

[JmillsExpensify]

$500 payment approved for @eVoloshchak based on BZ summary.

[laurenreidexpensify]

updated payment summary:

External issue reporter - @gadhiyamanan - $250, payment issued n Upwork
Contributor that fixed the issue - @tienifr - $500, payment issued in Upwork
Contributor+ that helped on the issue and/or PR - @eVoloshchak - $500 payment approved in newdot

[laurenreidexpensify]

@gadhiyamanan updated ^^

[tienifr]

Contributor that fixed the issue - @tienifr - $500, payment issued in Upwork

hi @laurenreidexpensify it seems payment wasn't issued for me yet, could you please take a look?

Thank you!

[tienifr]

hi @laurenreidexpensify it seems payment wasn't issued for me yet, could you please take a look?

@laurenreidexpensify could you help check the above comment? Thanks!

[laurenreidexpensify]

@tienifr huge apologies for the overlook here, the payment has been issued in Upwork now