[HOLD for payment 2023-10-30] [HOLD for payment 2023-09-29] [$500] Dev: Web - My note not translated in Spanish

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Preferences >Language
2. Change Language to Spanish
3. Create workspace if not created
4. Go to #admins
5. Click on header
6. Go to Private notes

Expected Result:

My note should be translated in Spanish

Actual Result:

My note not translated in Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.7.04.05.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694784868918699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a01358f997cc9909
• Upwork Job ID: 1703115340291780608
• Last Price Increase: 2023-09-16
• Automatic offers:
• namhihi237 | Contributor | 26746126
• gadhiyamanan | Reporter | 26746127

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"My note" should be translated when changing language to Spanish

What is the root cause of that problem?

We have some places hard-coding "My note". Therefore, when changing the language to Spanish, they will not be translated.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 90 in 76c1559

subtitle="My note"

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Line 110 in 76c1559

title: Number(lodashGet(session, 'accountID', null)) === Number(accountID) ? 'My note' : lodashGet(personalDetailsList, [accountID, 'login'], ''),

App/src/pages/PrivateNotes/PrivateNotesViewPage.js

Line 67 in 76c1559

subtitle={isCurrentUserNote ? 'My note' : `${lodashGet(personalDetailsList, [route.params.accountID, 'login'], '')} note`}

What changes do you think we should make in order to solve the problem?

We should make use of translate() and create translations for them.

translate('privateNotes.myNote')

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a01358f997cc9909

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

My note not translated in spanish

What is the root cause of that problem?

We are missing Localization logic for PrivateNotesFeature in PrivateNotesEditPage.js, PrivateNotesListPage.js and PrivateNotesViewPage.js

What changes do you think we should make in order to solve the problem?

The messages in this feature should refer to en.ts and spanish translation to es.ts

Then we will be using the useLocalize() hook

const {translate} = useLocalize();

to add Localization feature:

subtitle={translate('privateNotes.myNote')}

title: Number(lodashGet(session, 'accountID', null)) === Number(accountID) ? translate('privateNotes.myNote') : lodashGet(personalDetailsList, [accountID, 'login'], 

subtitle={isCurrentUserNote ? translate('privateNotes.myNote') : `${lodashGet(personalDetailsList, [route.params.accountID, 'login'], '')} note`}

What alternative solutions did you explore? (Optional)

[allroundexperts]

@neonbhai How is your proposal different from what @namhihi237 proposed earlier?

[neonbhai]

Hi @allroundexperts, added clear implementation details and line changes.

[allroundexperts]

@neonbhai Adding implementation details with a duplicated approach won't lead to your proposal getting accepted. One can write pseudo code only as well as long as the approach is clear enough. I would suggest you to write proposals that are different from the already existing ones.

[allroundexperts]

@namhihi237's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @namhihi237, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @namhihi237 got assigned: 2023-09-19 04:11:43 Z
• when the PR got merged: 2023-09-19 23:26:10 UTC

On to the next one 🚀

[alexpensify]

Here is the payment summary:

• External issue reporter: @gadhiyamanan $50
• Contributor that fixed the issue: @namhihi237 $750
• Contributor+ that helped on the issue and/or PR: @allroundexperts $750

Upwork Job: https://www.upwork.com/jobs/~01a01358f997cc9909

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: There is an urgency bonus here and will be applied during the payment process.

[alexpensify]

@allroundexperts please complete the checklist and request the payment.

Right now, everyone who is paid in Upwork has been paid there and I closed the job.

[allroundexperts]

Checklist

1. We forgot to add Spanish translation for this piece of text when we implemented this issue in this PR.
2. https://github.com/Expensify/App/pull/25761/files#r1343268376
3. Slack discussion not needed as we already have translation related points in our check list.
4. A regression test would be helpful.

Regression test steps

1. Login and change the language to Spanish.
2. Create workspace if not created and Go to #admins room
3. Click on header and go to Private notes

Verify that My note is seen as translated into Spanish as Mi notas

Do we 👍 or 👎 ?

[alexpensify]

Closing - the regression test request has been created for this case. I'm going to close this GH.

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.

[isagoico]

Reopening this issue because the current translation in app is not correct. It's showing "Mi notas" which is incorrect in Spanish.

It should either be:

1. For plural: My notes = Mis notas
2. For singular: My note = Mi nota

[tgolen]

Thank you for spotting this, Isa! @namhihi237 Can you please fix that?

I looked and I can't find a record of either me nor @allroundexperts checking to make sure that was an official translation. That's something we can learn from and do better at next time.

[namhihi237]

Sure I will raise PR next hours.

[namhihi237]

@tgolen PR already for review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @namhihi237 got assigned: 2023-09-19 04:11:43 Z
• when the PR got merged: 2023-10-19 21:58:35 UTC
• days elapsed: 22

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix translate my note es #29980

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @namhihi237 requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[alexpensify]

@allroundexperts and @gadhiyamanan - I'm considering closing with no payment updates. This is not a regression but was a quick fix. Everyone has already paid out already with bonuses in September. Let me know if you disagree.

cc: @tgolen

[allroundexperts]

Absolutely @alexpensify. That was my expectation as well.

[alexpensify]

Thanks! Closing for now.