[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Assign task - Long task description goes beyond the scope, doesn’t disappear after delete

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any Gmail account
3. On LHN, click on the FAB button
4. Select Assign Task
5. Enter a title and description
6. Change the description for a long text, for example long URL

Expected Result:

The Task description is fully visible

Actual Result:

Long task description goes beyond the scope

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.71-5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6205421_A_long_description_of_the_task_goes_beyond_the_field_and_does_not_disappear_when_delete_it.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[jeet-dhandha]

Same thing happenning for Private Notes. And it is also showing up like [link](link) which should not be the case.

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• On passing long text to description of Assign Task / Private Notes - the text is not wrapped.

What is the root cause of that problem?

• RenderHTML component is being rendered for these previews and it is not wrapping the text.

What changes do you think we should make in order to solve the problem?

• We can wrap the RenderHTML component with a View and set its style to chatItemMessage. This will wrap the text. (Got this idea from ReportPreview)

App/src/components/MenuItem.js

Lines 238 to 240 in 76b6914

	{Boolean(props.title) && Boolean(props.shouldRenderAsHTML) && <RenderHTML html={convertToLTR(props.title)} />}
	{Boolean(props.shouldParseTitle) && Boolean(html.length) && !props.shouldRenderAsHTML && <RenderHTML html={`<comment>${html}</comment>`} />}

<View style={styles.chatItemMessage}>
    <RenderHTML html={html} />
</View>

Output:

What alternative solutions did you explore? (Optional)

• N/A

[jeet-dhandha]

Happened due to My PR only 🥲 and also the private notes.

• Add private notes feature to newDot #25761
• fix: Parse Descriptions as Html for links #27462

[thienlnam]

@jeet-dhandha Can you spin up a PR for a fix?

[jeet-dhandha]

Sure

[jeet-dhandha]

@thienlnam One issue in native app. When i render below component it render's perfectly for Private notes as links are saved as [link](link) but in Assign Task we don't do that thus its not rendering and coming as empty.

<View style={styles.chatItemMessage}>
    <RenderHTML html={getProcessedTitle} />
</View>

But if i render without View in native app. It renders and wraps text perfectly.

<RenderHTML html={getProcessedTitle} />

What should we do ?

Solution 1:

• We should save description for assign task and money request like we have done in Private Notes.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 70 in 8af37c3

const editedNote = parser.replace(privateNote);

Solution 2:

• For native we render it conditionally.

(isNative ? (
    <RenderHTML html={getProcessedTitle} />
) : (
    <View style={styles.chatItemMessage}>
        <RenderHTML html={getProcessedTitle} />
    </View>
))

[jeet-dhandha]

Ready for review @thienlnam

[thienlnam]

Crap, I did not take a close enough look - we should not have added that platform specific code in there

[thienlnam]

I think we would update private notes to work the same way as task and money request descriptions

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] create common render for html and fix wrapping of title #27736

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @jeet-dhandha requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create different files for HTML Render and fix scroll width #27769

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @jeet-dhandha requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Payment due October 2nd

[melvin-bot]

@narefyev91, @thienlnam, @bfitzexpensify, @jeet-dhandha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jeet-dhandha]

Quick question: Amount and payment date ?

[bfitzexpensify]

Payment due today. @thienlnam I'm trying to piece together all of the parts of this. Seems like there were 3 different PRs, and it was potentially also identified as a deploy blocker in #27722 (comment).

Can you summarise what's happened in this issue so I can finalise those payments? Thanks

[bfitzexpensify]

Bump on #27722 (comment) @thienlnam

[thienlnam]

Yes, this was linked to a few regressions and a couple issues that were more like feature requests, so let's just do the standard single regression deduction for this one (50% deduction)

[bfitzexpensify]

Cool, thanks for clarifying. Offers have been sent out.

Also @narefyev91, a reminder to complete the BZ checklist when you get a chance - thanks!

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - current PR fixed most of the bugs which came
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - there were some issues which were linked to first PR, most of them were more like feature requests
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1695182982405449
• Determine if we should create a regression test for this bug:
  Regression tests:

First flow:

1. Create any task from FAB.
2. While creating the task in description enter any URL.
3. Verify that the URL is converted to a link.

Second flow:

1. Open any chat and open assign task modal.
2. Then add a long description including a url and press next.
3. Verify that the description should be wrapped and not overflow.

Third flow:

1. Go to any chat > chat header > Private note > My note
2. Create multiple lines
3. Add a code block markdown in the middle
4. Save it
5. The code block does not create empty lines below it in the note preview

[bfitzexpensify]

Sweet. Opened an issue for those regression tests. We're all done, thanks everyone