[DISTANCE] [$1000] LOW: mWeb / Safari- i icon and mapbox logo not displayed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27491

Action Performed:

1. Launch the app on mWeb safari
2. Open the global create menu and select Request money
3. Select the Distance tab if it is not already active

Expected Result:

Toggle attribution (i) icon at the bottom-right of the map and Mapbox logo at the bottom-left of the map displayed to select

Actual Result:

Icon and mapbox icon not displayed. (No issue in chrome mWeb)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71-7

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fbbf81efc9a06b4
• Upwork Job ID: 1706697994798551040
• Last Price Increase: 2023-10-19
• Automatic offers:
• abdulrahuman5196 | Reviewer | 27464745
• aswin-s | Contributor | 27464746

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[johncschuster]

@lanitochka17 for those of us less familiar with this new feature, can you please provide a video example of the incorrect behavior, as well as a video example of the correct behavior? I'd like to see the difference between what you spotted on Safari vs Chrome.

Thanks!

[m-natarajan]

@johncschuster I am attaching the video for reference.

RPReplay-Final1695160118.MP4

[akinwale]

This seems to be caused by the Smart App banner pushing down the elements, which can only be seen on the staging or production URLs. Still trying to figure out why.

There's an open PR that fixes a bug that occurs when the map container resizes. I am not sure if that would fix this, but it may be worth a shot to check it out.

EDIT: The PR is in staging now, but no dice.

[akinwale]

After doing some more digging, it turns out that when the Smart App Banner is displayed, it somehow messes up the z-indexes of the map and its controls, since it triggers a re-render of the map canvas, and the map ends up being rendered over the Mapbox logo and the toggle attribution icon, resulting in the controls being hidden.

Setting a z-index of -1 for the .mapboxgl-canvas CSS class seems to solve the rendering problem. However, this prevents the map from being interacted with (tap / touch / pan / zoom operations stop working).

[melvin-bot]

@johncschuster, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

[johncschuster]

Thanks for posting that video, @m-natarajan! That was very helpful!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015fbbf81efc9a06b4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[johncschuster]

@abdulrahuman5196 just a heads up, @akinwale has already shared what they believe is the cause in this comment.

[kameshwarnayak]

Unable to reproduce in the current main.

[johncschuster]

@lanitochka17 are you able to reproduce this on main?

[lanitochka17]

Issue is reproducible on Build 1.3.75-3

[abdulrahuman5196]

@johncschuster Not sure of the issue status here. Do let me know when this issue comes into proposal review phase. Would be happy to help review on proposals or any other help required

[kameshwarnayak]

@lanitochka17 Can you check on main. Cant reproduce. It might have been already fixed.

[melvin-bot]

@johncschuster @abdulrahuman5196 @lanitochka17 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

@aswin-s 's proposal here #27800 (comment) looks good and works well. Tested in different platforms and is working well. It could seem like a workaround to transform and fix but seems like the best and effective fix at the moment IMO.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

[aldo-expensify]

@aswin-s which account should I invite? @aswin-s or @aswin-s-kumar ?

[aswin-s]

@aldo-expensify You may use @aswin-s

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @aswin-s 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Issue present as part of the mapbox implementation.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open NewExpensify on Safari mWeb
2. Open Request Money page from global navigation
3. Open 'Distance' tab
4. Wait for the map to load
5. Verify that the MapBox logo and the information icon is shown at the bottom edge of the map

@johncschuster
Seems melvin bot didn't update here automatically. Seems the issue is in payment due for today - #30673 (comment)

[abdulrahuman5196]

@johncschuster Gentle ping on payment as mentioned above.

[aswin-s]

@johncschuster @dylanexpensify Gentle reminder on the payment.

[johncschuster]

Thanks for the bump! I'll get payment issued shortly!

[aswin-s]

Bump @johncschuster

[johncschuster]

Sorry team! I let this slip. Payment has now been issued!

[johncschuster]

I'll leave this open for me so I can get the regression steps

[melvin-bot]

This issue has not been updated in over 15 days. @johncschuster, @aswin-s, @abdulrahuman5196, @lanitochka17, @aldo-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!