Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Room - Paid policy isn't shown as an option under “Workspace”. #28046

Closed
1 of 6 tasks
kbecciv opened this issue Sep 22, 2023 · 18 comments
Closed
1 of 6 tasks

Web - Room - Paid policy isn't shown as an option under “Workspace”. #28046

kbecciv opened this issue Sep 22, 2023 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Sep 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found wen executing PR #26982

Action Performed:

  1. Sign into OldDot, create or navigate to an existing paid policy. Save the policyID.
  2. Run the following snippet to enabled chat rooms for the policy.
    const policyID = '';
    API.policy_get({policyIDList: policyID}).then((response) => {
    const policy = response.policies[policyID];
    policy.areChatRoomsEnabled = true;
    API.policy_save({policyID, value: policy});
  3. Sign into NewDot (you'll need to sign out first because of the new reliable updates changes). FAB > New Room.

Expected Result:

Verify the paid policy shows up as an option under "Workspace"

Actual Result:

Paid policy isn't shown as an option under “Workspace”

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6210945_26982_web.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@bfitzexpensify
Copy link
Contributor

Reproduced. @jasperhuangg, any insight on this one? It was discovered via #26982

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 25, 2023
@bfitzexpensify
Copy link
Contributor

Bump on #28046 (comment) @jasperhuangg

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bfitzexpensify
Copy link
Contributor

@jasperhuangg thoughts on #28046 (comment)?

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@bfitzexpensify
Copy link
Contributor

Another bump here @jasperhuangg

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@bfitzexpensify
Copy link
Contributor

@jasperhuangg not sure if you're seeing my bumps, so assigning it to you so it appears in your K2. Looking for your thoughts on #28046 (comment)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 6, 2023
@jasperhuangg
Copy link
Contributor

Ah, thanks for assigning me @bfitzexpensify. I wasn't receiving mention notifications for some reason. Taking a look.

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@jasperhuangg
Copy link
Contributor

The QAer didn't follow the steps correctly. The policyID they entered has carets around it <>. Those are placeholders and shouldn't actually appear in the policyID.

In addition, I'm noticing some other problems, fixing those in a PR

@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Oct 9, 2023
@bfitzexpensify
Copy link
Contributor

Sweet, thanks man

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@jasperhuangg, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

@jasperhuangg, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@jasperhuangg, @bfitzexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

@jasperhuangg, @bfitzexpensify 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@jasperhuangg, @bfitzexpensify 12 days overdue now... This issue's end is nigh!

@bfitzexpensify
Copy link
Contributor

Looks like https://github.com/Expensify/Web-Expensify/pull/39143 was deployed to prod a couple of weeks ago - I can't reproduce any more, so I think we're good to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants