[HOLD for payment 2023-10-10] 3 dot menu - "Mark as Done" appears both as a button and in the 3 dot menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27748

Action Performed:

1. Access staging.new.expensify.com
   2 Sign into a valid account
2. Assign a task to any chat
3. Go to task chat, and observe the 3 dot menu in the upper right corner

Expected Result:

User expects all items to be within the 3 dot menu now

Actual Result:

"Mark as complete" is both a green button and also within the 3 dot menu. Both the buttons have the same function so no reason to be repeated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112dfc2656f23b7d3
• Upwork Job ID: 1707555311776894976
• Last Price Increase: 2023-09-29

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[Christinadobrzyn]

I can reproduce - not sure what button we want to remove

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112dfc2656f23b7d3

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

I'm not sure if I should have added the Interal label... I don't know if we need those on deploy blockers...

[MariaHCD]

@Christinadobrzyn, I think we should confirm in #expensify-open-source what the expected UI is here :)

Not a deploy blocker, tho!

[aimane-chnaif]

@Expensify/design may help here

[dubielzyk-expensify]

My take is that we should remove the "Mark as complete" in the overflow menu as it would be too hidden if we remove the green button. The primary action of a task would be to Mark is at complete. So it should look like this:

But keen to hear what @shawnborton or @dannymcclain thinks.

[dannymcclain]

I feel like I agree with @dubielzyk-expensify, but am curious if there's some previous decision that's been made that I'm missing. I think about it the same way though—the primary action for a task is to complete it, so it makes sense that it would be an ever-present big green button.

Similar to how on a report/request, the primary action is to pay it, so we show that as a big green button.

IMO this action is distinct from and more important than the typical actions you'd find in the 3-dot menu (ie "pin").

[MariaHCD]

Thanks for the input, @dannymcclain @dubielzyk-expensify! I agree that we should keep the big green button and remove the item from the dropdown as illustrated here

[ishpaul777]

Proposal

Problem

"Mark as Done" appears both as a button and in the 3 dot menu

Root cause

no root cause, more like a feature improvement

Changes

we should keep the big green button and remove the item from the dropdown as illustrated here

Considering above to be expected We can remove the below from here.

if (ReportUtils.isOpenTaskReport(props.report) && canModifyTask) {
            threeDotMenuItems.push({
                icon: Expensicons.Checkmark,
                iconFill: themeColors.icon,
                text: props.translate('task.markAsComplete'),
                onSelected: () => Task.completeTask(props.report),
            });
        }

Result

Screen.Recording.2023-09-29.at.3.57.52.PM.mov

[MariaHCD]

Thanks, @ishpaul777 but this issue is labelled as internal and so we're not accepting proposals here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Mark as complete menu item from threeDotMenuItems for tasks #28582

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

hey @aimane-chnaif do you think a regression test is needed for this?

Payouts due:

Issue Reporter: NA
Contributor: NA
Contributor+: $500 @aimane-chnaif (paid in Upwork)

Eligible for 50% #urgency bonus? No since this was internal

Upwork job is here.

[aimane-chnaif]

This is from new design. No need regression test

[Christinadobrzyn]

Awesome! Thanks @aimane-chnaif

I paid you in Upwork based on this payment overview - #28421 (comment)