[HOLD for payment 2023-10-25] [$500] Chat - App closes mention suggestions when cursor is between double @

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open the app
2. Open any report
3. Write @, it will trigger mention suggestions
4. Write any letter, number or symbol after it
5. Take it cursor back to position after the @ and observe that app again displays mention suggestions
6. Clear everything and write double @@
7. Take cursor back to position after the first @ and observe that app does not display mention suggestions

Expected Result:

App should display mention suggestions according to cursor position and text before it

Actual Result:

App does not display mention suggestions even though @ is present before cursor if @ is also present after cursor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

android.native.double.@.mention.issue.mp4

android.chrome.double.@.mention.issue.mp4

windows.chrome.double.@.mention.issue.mp4

ios.native.safari.double.@.mention.issue.mov

mac.chrome.double.@.mention.issue.mov

mac.desktop.double.@.mention.issue.mov

Recording.4843.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696338120628179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e08f14329a2fd98
• Upwork Job ID: 1709321185861791744
• Last Price Increase: 2023-10-10
• Automatic offers:
• paultsimura | Contributor | 27123369
• dhanashree-sawant | Reporter | 27123379

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e08f14329a2fd98

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Placing a cursor in between consecutive @ signs doesn't show the name suggestions.

What is the root cause of that problem?

We are using a RegExp that no longer exists (CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI) to calculate the end of the next word after the cursor:

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 191 in a4f4a77

const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI);

As a result, the value of indexOfFirstWhitespaceCharOrEmojiAfterTheCursor is always 0 (as RegExp is undefined), and the calculation logic is broken.

What changes do you think we should make in order to solve the problem?

We should replace the non-existing RegExp with the one that replaced it in #19004

-           const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.NEW_LINE_OR_WHITE_SPACE_OR_EMOJI);
+           const indexOfFirstWhitespaceCharOrEmojiAfterTheCursor = valueAfterTheCursor.search(CONST.REGEX.SPECIAL_CHAR_OR_EMOJI);

Result:

double-mention.mov

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Hey team! Do you think this GH has the same root and therefore the same fix? #28753

[paultsimura]

Hey @Christinadobrzyn , even though I'm not a part of the Internal team:
#28753 is a regression from the recently merged #28045

And this issue (#28754) existed relatively long before that regression – at least since #25758.

[parasharrajat]

@paultsimura 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[paultsimura]

PR's ready: #29239

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @paultsimura got assigned: 2023-10-10 16:32:49 Z
• when the PR got merged: 2023-10-17 06:13:13 UTC
• days elapsed: 4

On to the next one 🚀

[paultsimura]

Melvin, the PR was waiting on the Engineer's approval and merge only. It was ready in 2 days🫡

[mallenexpensify]

@paultsimura in the future, if you disagree with Melvin (which happens... occassionally) please link to time stamps in the PR. ie.

• C+ approved PR Oct 12 - fix: Chat - App closes mention suggestions when cursor is between double @ #29239 (review)
• No other changes were needed between C+ approval and PR being merged (I think this is correct, from what I can see. It's a necessary part for reconsidering timing).
• Internal engineer merged Oct 16th - fix: Chat - App closes mention suggestions when cursor is between double @ #29239 (review)

[paultsimura]

@paultsimura in the future, if you disagree with Melvin (which happens... occassionally) please link to time stamps in the PR.

Thank you, noted ✅

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[paultsimura]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Responded in the referenced issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Chat - App closes mention suggestions when cursor is between double @ #29239

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment offer (Contributor)
• @parasharrajat does not require payment (Eligible for Manual Requests)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Issue reporter: @dhanashree-sawant paid $50 via Upwork
Contributor: @paultsimura paid $750 via Upwork, inc. urgency bonus (see above)
Contributor+: @parasharrajat due $750 via NewDot

@parasharrajat , can you please fill out the BZ checklist? Thx

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Performance: chat input #25758
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25758/files#r1373789220
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a [regression test] (https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md?rgh-link-date=2023-06-22T16%3A41%3A44Z) for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Open any report
2. Write @, it will trigger mention suggestions
3. Write @gmail (or any other email domain that is present in your contacts) after the first "@". It should be looking like @@gmail now.
4. Place the cursor right after the first "@".
5. Verify that the mention suggestions are still open.
6. Verify that the search is happening by the whole word up until the space or a special character, regardless of the cursor position on the word from first @.

Do you agree 👍 or 👎 ?

[melvin-bot]

@madmax330, @paultsimura, @mallenexpensify, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[madmax330]

@mallenexpensify can you review the BZ checklist when you get a chance?

[mallenexpensify]

Thanks @parasharrajat !
Regression test GH

• https://github.com/Expensify/Expensify/issues/331503

Payment confirmation above is complete and up to date

[parasharrajat]

Payment requested as per #28754 (comment)

[JmillsExpensify]

$750 payment approved for @parasharrajat based on this comment.