[HOLD for payment 2023-10-30] [$250] IOU - Text under "category" header is not displayed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/

2. Tap on Workspace chat

3. Tap plus icon

4. Tap request money

5. Enter an amount

6. Tap next

7. Tap show more

8. Tap categories

Expected Result:

In the header " category" , the text "Select a category to help organize your money, or we’ll auto-categorize it for you” must be displayed

Actual Result:

In the header " category" , the text "Select a category to help organize your money, or we’ll auto-categorize it for you” is not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226344_1696531344558.header_text.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01298a914a67495601
• Upwork Job ID: 1710257172167360512
• Last Price Increase: 2023-10-09
• Automatic offers:
• DylanDylann | Contributor | 27123526

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text under category header is not displayed

What is the root cause of that problem?

We are missing the text on the EditRequestCategoryPage

What changes do you think we should make in order to solve the problem?

We should add the text to src/languages and add it to EditRequestCategoryPage

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text under "category" header is not displayed

What is the root cause of that problem?

Let's see the Tag Page (MoneyRequestTagPage Component), we are displaying the subtitle

But in the Edit Tag page (EditRequestTagPage Component), Category Page and Edit Category Page, we don't have logic to display the subtitle.

What changes do you think we should make in order to solve the problem?

1. Edit Tag page (EditRequestTagPage Component)
   Add a new Text like we did in MoneyRequestTagPage Component
   

   App/src/pages/iou/MoneyRequestTagPage.js

   Line 84 in 779a1e5

   <Text style={[styles.ph5, styles.pv3]}>{translate('iou.tagSelection', {tagName: policyTagListName})}</Text>

2. For Category Feature
   We need to define new translation key like we did with tag feature
   

   App/src/languages/en.ts

   Line 561 in 779a1e5

   tagSelection: ({tagName}: TagSelectionParams) => `Select a ${tagName} to add additional organization to your money`,

Then add the subtitle to Category Page and Edit Category Page like we did with Tag feature above

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[laurenreidexpensify]

Isa is OOO, manually reassigning to move forward while she's offline

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01298a914a67495601

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

@greg-schroeder, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Upwork job price has been updated to $250

[puneetlath]

@greg-schroeder I'll take this over from you. Looks like this was just an oversight when we implemented the page.

I'm going to reduce this to a $250 issue. @DylanDylann if you are still down for it, your solution seems to make sense to me. But let's wait for @Santhosh-Sellavel to weigh in as well.

[Santhosh-Sellavel]

Yes, @DylanDylann's Proposal looks good to me!
C+ Reviewed
🎀 👀 🎀

@puneetlath But How to test tags?

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[aimane-chnaif]

I am assigned as reviewer in PR.
Shall I review? or @Santhosh-Sellavel will do? (not sure why @Santhosh-Sellavel was unassigned here)

[Santhosh-Sellavel]

@puneetlath I'm confused too, why did I get unassigned here?

[puneetlath]

@Santhosh-Sellavel my bad, must've done that on accident. I've re-assigned you.

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Contributor role ($250)

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @DylanDylann got assigned: 2023-10-10 16:40:59 Z
• when the PR got merged: 2023-10-20 19:28:40 UTC
• days elapsed: 8

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/28952: Add subtitle to category page #29266

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
• @DylanDylann requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@Santhosh-Sellavel friendly reminder on the checklist so we can pay 😄

[melvin-bot]

@puneetlath, @Santhosh-Sellavel, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@Santhosh-Sellavel just waiting on the checklist.

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Category MenuItem and CategoryPicker component #25470
  Allow Viewing/Editing a category on a Money Request #27459
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Category MenuItem and CategoryPicker component #25470 (comment) Allow Viewing/Editing a category on a Money Request #27459 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A As said this is little oversight we can skip this
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. I guess not, because it is from applause/QA should already have this covered.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@puneetlath Let me know if you differ on any of the above, thanks!

[puneetlath]

Payment summary:

• C @DylanDylann - $250 (paid via Upwork)
• C+ @Santhosh-Sellavel - $250 (to be paid on NewDot)

@Santhosh-Sellavel please go ahead and request payment on NewDot.

[JmillsExpensify]

$250 payment approved for @Santhosh-Sellavel based on comment above.