-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Viewing/Editing a category on a Money Request #27459
Allow Viewing/Editing a category on a Money Request #27459
Conversation
…ture/24464-editing-category-money-request
…ture/24464-editing-category-money-request
…ture/24464-editing-category-money-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @rezkiy37
@mananjadhav Yep go ahead please, you need to enable all betas and also this will only work with optimistic udpates, backend is not deployed yet |
@mananjadhav feel free to amend my checklist with screenshots when you have them. |
…ture/24464-editing-category-money-request
96ad0fc
Unit tests seem to be failing @rezkiy37 |
…ture/24464-editing-category-money-request
There was a minor mistake after merging. Just fixed 🙂 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.73-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀
|
We failed to add subtitle for the Edit category page which resulted in this regression #28952 |
Details
The PR introduces a flow to view and edit a category on an already created money request.
Also, in a scope of this PR, there is a fix to hide categories/tags for DM.
Fixed Issues
$ #24464, #27556
PROPOSAL: N/A
Tests
Note:
newDotCategories
.1. Viewing a Money Request with a category
2. Viewing a Money Request without a category
3. Viewing a Money Request within private messages
4. Editing a category on a Money Request
5. Editing a Money Request without an initial category
6. The Category/Tag selector does not show up in DM Money Requests
A couple of other notes about editing categories:
If a category is disabled, but was already selected on a Money Request, when the user clicks the category to edit it, the disabled but selected category will show in the "Selected Category" section. Unselecting it will make it disappear since the user will be navigated back to the expense, saving an empty category on it.
If categories are completely disabled, or there are no enabled categories on the policy, but there is a category on an expense…
When the user clicks the category to edit it, the lone category will be shown as the only category in the policy.
This will use the "simplified" < 8 categories view.
Deselecting the category will again navigate the user back to the expense.
This time, because there are no categories on the policy and no category is selected, the Category menu item will disappear.
Verify that no errors appear in the JS console
Offline tests
1. Editing a category on a Money Request
QA Steps
Same as "Test" and "Offline tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
all-disabled_qt6lgRpq.mp4
Selected.disabled.mov
Mobile Web - Chrome
IOS.Chrome.MP4
Mobile Web - Safari
IOS.Safari.MP4
Desktop
Desktop.mov
iOS
IOS.mov
Android
Android.mov