[$500] mWeb - FAB - Fab button glitches on mWeb Safari #29436

kbecciv · 2023-10-12T12:54:57Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @studentofcoding
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696921511329039

Action Performed:

Login to https://staging.new.expensify.com/ on Safari
Click FAB and choose Assign task or other menu
Go back to Homepage and see that the FAB is glitches

Expected Result:

Fab button doesn't glitch on mWeb Safari

Actual Result:

Fab button glitches on mWeb Safari

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

RPReplay_Final1696954093.1.MP4

FAB_glitches.MP4

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01be79a8ad5b8b30d6
Upwork Job ID: 1712451800961429504
Last Price Increase: 2023-11-02

melvin-bot · 2023-10-12T12:55:02Z

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

kbecciv · 2023-10-12T12:55:03Z

Proposal by: @studentofcoding
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696921511329039

Proposal

Please re-state the problem that we are trying to solve in this issue

FAB - Glitches on mWeb Safari iPhone

What is the root cause of that problem?

We still haven’t managed the homepage URL structure into our apple-app-site-association file, therefore the layout changes on the Homepage that are the result of Smart App Banner not showing make the ‘FAB’ Button glitches

What changes do you think we should make in order to solve the problem?

Add homepage into apple-app-site-association like what we recently have on #28020

What alternative solutions did you explore? (Optional)

We can try to make the FAB button fixed via css but this is a workaround and I prefer to fix it via apple-app-site-association

melvin-bot · 2023-10-12T12:55:03Z

Job added to Upwork: https://www.upwork.com/jobs/~01be79a8ad5b8b30d6

melvin-bot · 2023-10-12T12:55:04Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-12T12:55:10Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

abdulrahuman5196 · 2023-10-15T07:04:36Z

@studentofcoding It seems we have been making the same fix at couple of places in the recent PRs.

Can we identify all the pages which have this issue and fix all the pages at once?

studentofcoding · 2023-10-17T06:05:48Z

@studentofcoding It seems we have been making the same fix at couple of places in the recent PRs.

Can we identify all the pages which have this issue and fix all the pages at once?

Yes we have had this problem 2 times before @abdulrahuman5196 and with the recent layout change on Homepage sidebar, this problem is appearing on the page

Let me check on the other page as well and I will update it soon

studentofcoding · 2023-10-18T04:29:39Z

Hey @abdulrahuman5196, after checking all the routes and pages, the remaining ones besides Homepage are on send money-related below

IOU_SEND: 'send/new',
IOU_SEND_ADD_BANK_ACCOUNT: 'send/new/add-bank-account',
IOU_SEND_ADD_DEBIT_CARD: 'send/new/add-debit-card',
IOU_SEND_ENABLE_PAYMENTS: 'send/new/enable-payments',

In which we can add this via

{
        "/": "/send/*",
        "comment": "Send money"
},

Note: as send-money it's a on-progress area, we might need the confirmation if we want to include it now, or later

melvin-bot · 2023-10-18T12:22:09Z

@sakluger, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

sakluger · 2023-10-18T16:43:19Z

@abdulrahuman5196 can you link me the other PRs where we fixed similar issues? I'd like to bring this issue to the team that is working on the layout changes.

melvin-bot · 2023-10-19T16:00:23Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

abdulrahuman5196 · 2023-10-23T12:02:06Z

Checking now

abdulrahuman5196 · 2023-10-23T12:27:51Z

@abdulrahuman5196 can you link me the other PRs where we fixed similar issues? I'd like to bring this issue to the team that is working on the layout changes.

@sakluger

#26172
#28222

abdulrahuman5196 · 2023-10-23T12:28:43Z

@studentofcoding

What url will you add for homepage in the apple-app-site-association file? Can you add the information in the proposal?

studentofcoding · 2023-10-24T05:17:58Z

Sure @abdulrahuman5196

Below is the updated proposal:

Proposal

Please re-state the problem that we are trying to solve in this issue

FAB - Glitches on mWeb Safari iPhone

What is the root cause of that problem?

We still haven’t managed the homepage URL structure into our apple-app-site-association file, therefore the layout changes on the Homepage that are the result of Smart App Banner not showing make the ‘FAB’ Button glitches

What changes do you think we should make in order to solve the problem?

Add homepage into apple-app-site-association like what we recently have on #28020

In this case, based on the [Apple documentation here], (https://developer.apple.com/documentation/bundleresources/applinks/details/components) as the homepage didn't have any additional path, therefore we have to use "*" as the path. But because this structure also takes any path, in the future we need to exclude any path that we didn't want to include.

{
        "/": "*",
        "comment": "Homepage"
},
{
        "/": "/any/*",
        "exclude": true,
        "comment": "Matches any URL whose path starts with /any/* and instructs the system not to open it as a universal link"
},

What alternative solutions did you explore? (Optional)

We can try to make the FAB button fixed via CSS but this is a workaround and I prefer to fix it via apple-app-site-association

abdulrahuman5196 · 2023-10-25T19:07:34Z

But because this structure also takes any path, in the future we need to exclude any path that we didn't want to include.

I don't think we should do this. It will only create unwanted code burden to maintian.
We should look for other ways to solve this. @studentofcoding

melvin-bot · 2023-10-26T12:50:19Z

@sakluger @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

rezkiy37 · 2023-11-06T17:23:46Z

@abdulrahuman5196, I cannot reproduce the bug. The button behaves properly on simulators and real device.

Sorry, I have a trouble with uploading a video.

rezkiy37 · 2023-11-06T17:35:28Z

FAB.Button.1.mp4

rezkiy37 · 2023-11-07T17:16:45Z

@sakluger, @abdulrahuman5196, @kbecciv, could you please take a look at a comments above 🙂

bfitzexpensify · 2023-11-08T14:08:32Z

@studentofcoding are you still able to reliably reproduce?

studentofcoding · 2023-11-08T14:18:52Z

Let me check and get back to you

…

On Wed, Nov 8, 2023 at 9:08 PM Ben Fitzpatrick ***@***.***> wrote: @studentofcoding <https://github.com/studentofcoding> are you still able to reliably reproduce? — Reply to this email directly, view it on GitHub <#29436 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4GNNWFRWQB23VTBEM56Y3YDOG6XAVCNFSM6AAAAAA55SNAS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRHE3DGNJZGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- * Yonathan Evan C.* * Senior Front-end Engineer* w: *https://gictech.xyz/ <https://gictech.xyz/>* m: (+62) 821 4680 4530 a: Multivision Tower 25th Floor, Jl. Kuningan Mulia Lot 9B, RT.6/RW.1, Menteng Atas, RT.6/RW.1, Menteng Atas, Menteng, Kota Jakarta Selatan, Daerah Khusus Ibukota Jakarta 12980 e: ***@***.*** ***@***.***>

melvin-bot · 2023-11-09T13:49:31Z

@sakluger @bfitzexpensify @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot · 2023-11-09T13:49:39Z

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

bfitzexpensify · 2023-11-09T15:15:25Z

Any luck @studentofcoding?

abdulrahuman5196 · 2023-11-13T08:48:56Z

Need to check if bug is reproducible

sakluger · 2023-11-13T22:41:27Z

I tried reproducing this, but looking back at the reproduction steps and original video, I am not 100% sure what is meant by "FAB button glitches". How exactly does it glitch? @kbecciv since you verified the bug report and created the issue, maybe you can check if it's reproduceable, and if so, clarify how it's glitching? Thanks!

rezkiy37 · 2023-11-16T15:27:50Z

@kbecciv, bump.

rezkiy37 · 2023-11-16T15:28:30Z

Waiting on someone's decision.

abdulrahuman5196 · 2023-11-16T15:57:20Z

Waiting on @kbecciv to check if the issue is reproducible

kbecciv · 2023-11-16T17:32:35Z

@abdulrahuman5196 Checking, will update you shortly

kbecciv · 2023-11-16T17:35:58Z

Not reproduced on current build 1.4.0

RPReplay_Final1700156063.1.MP4

abdulrahuman5196 · 2023-11-16T20:32:33Z

Thank you @kbecciv

@sakluger The UI is changed and the issue doesn't appear anymore. We can close this issue.

melvin-bot · 2023-11-20T12:57:39Z

@sakluger, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

greg-schroeder · 2023-11-21T06:53:15Z

closing per above

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023

melvin-bot bot assigned sakluger Oct 12, 2023

melvin-bot bot changed the title ~~mWeb - FAB - Fab button glitches on mWeb Safari~~ [$500] mWeb - FAB - Fab button glitches on mWeb Safari Oct 12, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

melvin-bot bot assigned abdulrahuman5196 Oct 12, 2023

melvin-bot bot added the Overdue label Oct 18, 2023

melvin-bot bot removed the Overdue label Oct 18, 2023

melvin-bot bot added the Overdue label Oct 23, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

melvin-bot bot added the Overdue label Oct 25, 2023

melvin-bot bot removed the Overdue label Oct 25, 2023

melvin-bot bot removed the Overdue label Nov 6, 2023

melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 9, 2023

melvin-bot bot added the Overdue label Nov 13, 2023

melvin-bot bot removed the Overdue label Nov 13, 2023

bfitzexpensify removed their assignment Nov 15, 2023

melvin-bot bot added the Overdue label Nov 16, 2023

melvin-bot bot removed the Overdue label Nov 16, 2023

melvin-bot bot added the Overdue label Nov 20, 2023

greg-schroeder closed this as completed Nov 21, 2023

melvin-bot bot removed the Overdue label Nov 21, 2023

[$500] mWeb - FAB - Fab button glitches on mWeb Safari #29436

[$500] mWeb - FAB - Fab button glitches on mWeb Safari #29436

Comments

kbecciv commented Oct 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

kbecciv commented Oct 12, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 12, 2023

abdulrahuman5196 commented Oct 15, 2023

studentofcoding commented Oct 17, 2023

studentofcoding commented Oct 18, 2023 • edited Loading

melvin-bot bot commented Oct 18, 2023

sakluger commented Oct 18, 2023

melvin-bot bot commented Oct 19, 2023

abdulrahuman5196 commented Oct 23, 2023

abdulrahuman5196 commented Oct 23, 2023

abdulrahuman5196 commented Oct 23, 2023 • edited Loading

studentofcoding commented Oct 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

abdulrahuman5196 commented Oct 25, 2023 • edited Loading

melvin-bot bot commented Oct 26, 2023

rezkiy37 commented Nov 6, 2023 • edited Loading

rezkiy37 commented Nov 6, 2023

rezkiy37 commented Nov 7, 2023

bfitzexpensify commented Nov 8, 2023

studentofcoding commented Nov 8, 2023 via email

melvin-bot bot commented Nov 9, 2023

melvin-bot bot commented Nov 9, 2023

bfitzexpensify commented Nov 9, 2023

abdulrahuman5196 commented Nov 13, 2023

sakluger commented Nov 13, 2023

rezkiy37 commented Nov 16, 2023

rezkiy37 commented Nov 16, 2023

abdulrahuman5196 commented Nov 16, 2023

kbecciv commented Nov 16, 2023

kbecciv commented Nov 16, 2023

abdulrahuman5196 commented Nov 16, 2023

melvin-bot bot commented Nov 20, 2023

greg-schroeder commented Nov 21, 2023

kbecciv commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

kbecciv commented Oct 12, 2023 •

edited

Loading

studentofcoding commented Oct 18, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 23, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 25, 2023 •

edited

Loading

rezkiy37 commented Nov 6, 2023 •

edited

Loading