[$500] [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Web - Drag and drop feature works on Scan and Distance request money

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Start the request money flow and select "Scan"
2. Drag and drop a receipt on the scan modal
3. Select Distance option
4. Drag and drop a receipt on the distance modal

Expected Result:

Drag and drop feature works on Scan and Distance request money

Actual Result:

Drag and drop feature works on Scan and Distance request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Recording.575.mp4

Recording.5104.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ae828d7f55c050d
• Upwork Job ID: 1719123208894443520
• Last Price Increase: 2023-10-30

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Drag and drop available for distance request as well

What is the root cause of that problem?

We are subscribing to incorrect key here

    withOnyx({
        selectedTab: {
            key: `${ONYXKEYS.SELECTED_TAB}_${CONST.TAB.RECEIPT_TAB_ID}`,
        },
    }),

What changes do you think we should make in order to solve the problem?

We should subscribe to

selectedTab: {
        key: `${ONYXKEYS.COLLECTION.SELECTED_TAB}${CONST.TAB.RECEIPT_TAB_ID}`,
    },

What alternative solutions did you explore? (Optional)

[ishpaul777]

regression from #26149

[situchan]

@dukenv0307 are you able to raise quick PR?
SELECTED_TAB is moved to collections in #26932 but your PR didn't reflect that.

[luacmartins]

We merged a fix already

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Gonna have to pay 25% to @c3024 so $125 for their help! Thanks @alexpensify

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Incorrect onyx key for selected tab #30151

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[greg-schroeder]

(Oops, posted in wrong issue, sorry)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix Incorrect onyx key for selected tab #30151

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mountiny]

Gonna have to pay 25% to @c3024 so $125 for their help! Thanks @alexpensify

[alexpensify]

Cool, the payment date is 10-31! I'll prepare for that date.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ae828d7f55c050d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[alexpensify]

@narefyev91 - disregard this one. I needed to create an Upwork job.

[alexpensify]

@c3024 - to prepare for the payment date, can you please apply to this Upwork job:

https://www.upwork.com/jobs/~011ae828d7f55c050d

Thanks!

[c3024]

Applied. Thanks @alexpensify

[alexpensify]

@c3024 - thanks, I sent an offer in Upwork.

[c3024]

Accepted.

[alexpensify]

Done! I've finished the payment process in Upwork.