Web - App allows user to open request money link of other user and displays amount page twice #26149

dukenv0307 · 2023-08-29T07:28:45Z

Details

Web - App allows user to open request money link of other user and displays amount page twice

Fixed Issues

$ #23755
PROPOSAL: #23755 (comment)

Tests

Request money with invalid reportID

Open a chat report
Click on the plus icon > Request money
Enter a valid amount and continue
Copy the URL of the confirm page
Paste the URL to composer, edit the reportID param to an invalid value, and send the message
Click on the URL that is sent and verify that the not found page appears

The report that cannot create the money request

Open a chat report
Click on the plus icon > Request money
Copy the URL of the selector page
Paste the URL to composer, edit the reportID param to a report that cannot create the request money. i.e. the ID of the group chat or announce room, and send the message
Click on the URL and verify that the not found page appears

Request money with global FAB

Go to FAB > Request money
Verify the selector page is displayed without loading
Open the participant page via deep link without entering an amount
Verify that it will reset to the selector page
Repeat step 3 with the confirm page, and merchant page and verify that the result is the same

Test the HOC for some other components

Open the report detail page
Edit the URL with an invalid reportID
Verify that after loading, the not found page appears
Repeat the same step with report participant page, report setting page, report share code page
Verify that the result is the same

Verify that no errors appear in the JS console

Offline tests

QA Steps

Request money with invalid reportID

Open a chat report
Click on the plus icon > Request money
Enter a valid amount and continue
Copy the URL of the confirm page
Paste the URL to composer, edit the reportID param to an invalid value, and send the message
Click on the URL that is sent and verify that the not found page appears

The report that cannot create the money request

Open a chat report
Click on the plus icon > Request money
Copy the URL of the selector page
Paste the URL to composer, edit the reportID param to a report that cannot create the request money. i.e. the ID of the group chat or announce room, and send the message
Click on the URL and verify that the not found page appears

Request money with global FAB

Go to FAB > Request money
Verify the selector page is displayed without loading
Open the participant page via deep link without entering an amount
Verify that it will reset to the selector page
Repeat step 3 with the confirm page, and merchant page and verify that the result is the same

Test the HOC for some other components

Open the report detail page
Edit the URL with an invalid reportID
Verify that after loading, the not found page appears
Repeat the same step with report participant page, report setting page, report share code page
Verify that the result is the same

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Request money with invalid reportID

web.3.mp4

The report that cannot create the money request

Screencast.from.19-09-2023.15.18.08.webm

Request money with global FAB

Screencast.from.19-09-2023.15.37.37.webm

Test the HOC for some other components

Screencast.from.19-09-2023.15.44.24.webm

Mobile Web - Chrome

- Request money with invalid `reportID`

chrome.mov

The report that cannot create the money request

Record_2023-09-19-15-38-43.mp4

Request money with global FAB

Record_2023-09-19-15-26-38.mp4

Test the HOC for some other components

Record_2023-09-19-15-45-57.mp4

Mobile Web - Safari

- Request money with invalid `reportID`

safari.mov

The report that cannot create the money request

Screen.Recording.2023-09-19.at.15.32.08.mp4

Request money with global FAB

Screen-Recording-2023-09-19-at-15.41.07.mp4

Test the HOC for some other components

Screen-Recording-2023-09-19-at-15.47.01.mp4

Desktop

- Request money with invalid `reportID`

desktop.mov

The report that cannot create the money request

Screen.Recording.2023-09-19.at.15.59.39.mov

Request money with global FAB
Test the HOC for some other components

Screen-Recording-2023-09-19-at-16.44.31.mp4

iOS

- Request money with invalid `reportID`

ios.mov

The report that cannot create the money request

Screen.Recording.2023-09-19.at.15.50.35.mp4

Request money with global FAB

Screen-Recording-2023-09-19-at-15.52.13.mp4

Test the HOC for some other components

Screen.Recording.2023-09-19.at.15.52.55.mp4

Android

- Request money with invalid `reportID`

android.mov

The report that cannot create the money request

23755-1.webm

Request money with global FAB

23755-2.mp4

Test the HOC for some other components

223755-3.mp4

melvin-bot · 2023-09-14T03:35:48Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2023-09-15T07:15:12Z

@dukenv0307 Let's add test steps for some other components which use withReportOrNotFound. Please add some tests for case of Report Not Found and some for regular flow.

dukenv0307 · 2023-09-17T11:16:08Z

@sobitneupane I updated the test step. Do you agree with this? And I will update the screenshots if you agree.

dukenv0307 · 2023-09-19T05:05:19Z

@sobitneupane Any update here #26149 (comment).

sobitneupane · 2023-09-19T07:26:12Z

@dukenv0307 Yup. Test steps look good.

dukenv0307 · 2023-09-19T09:52:47Z

@sobitneupane I updated all screenshots. For the case 3 in desktop, because this issue #27085 always happens in desktop, I will update this after this issue is merged.

sobitneupane · 2023-09-20T05:59:02Z

@sobitneupane I updated all screenshots. For the case 3 in desktop, because this issue #27085 always happens in desktop, I will update this after this issue is merged.

This issue is blocking me from testing. Fortunately, I am assigned to the issue. I will try to get it merged today. After that I will continue the review.

Other than that, @dukenv0307 I'm encountering a 'Not Found' page when attempting to request money from FAB.

dukenv0307 · 2023-09-20T06:15:30Z

@sobitneupane Can you share the test step?

sobitneupane · 2023-09-20T06:25:35Z

@dukenv0307

FAB > Request Money is basically what I did. I might have shared a link of Money Request confirmation page before that.

sobitneupane · 2023-09-26T09:46:34Z

@dukenv0307 As of now, this PR only solves the issue for /request/new/confirmation but not for /request/new/confirmation/123.

Will the case of /request/new/confirmation/123 handled by this PR? As we are aware of the expected output of the case, can we handle it here? It doesn't look like a complex case.

dukenv0307 · 2023-09-26T09:51:31Z

@sobitneupane It's not complex so I think we can handle this here. The root cause is invalid reportID makes report undefined and the app crashes. We only need to make the safe condition here

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Line 396 in 85a9c5f

key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`,

dukenv0307 · 2023-09-27T03:32:48Z

@sobitneupane This is fixed in latest main.

sobitneupane · 2023-10-02T08:23:32Z

@dukenv0307 This issue is still reproducible in my end. Did you get chance to look at it?

Screen.Recording.2023-10-02.at.14.07.17.mov

dukenv0307 · 2023-10-02T08:34:15Z

@sobitneupane This still works well in my end

Screencast.from.02-10-2023.15.33.37.webm

sobitneupane · 2023-10-02T09:09:16Z

@dukenv0307 Bit surprising, but it's not working on my end. I'm not sure of the exact reason; maybe some beta feature enabled on my account is causing the crash. Could you try it with a highly trafficked account?

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

dukenv0307 · 2023-10-05T10:34:08Z

@sobitneupane Just updated the code the fix the case in #27113 as well

dangrous · 2023-10-05T16:31:38Z

Hi! It looks like this has expanded just a little since the proposal, do you mind giving me a summary of the new ideas? I think the things I noticed are:

The new canCreateRequest method and using isAllowedToCreateRequest in MoneyRequestSelectorPage - it sort of feels like this makes the changes to withReportOrNotFound more unnecessary? but I am technically out of office so may have vacation brain :)
The isArchived check in MoneyRequestConfirmPage
Removing the useEffect from NewRequestAmountPage - is this because it will never be shown due to the canCreateRequest stuff up above?
Not a question - does doesRequireReportID or requiresReportID make more sense for our parameter name? isRequireReportID feels strange to me.

Nothing is standing out as bad, but I would love some of the context before doing a full review - thank you!

dukenv0307 · 2023-10-05T16:46:46Z

@dangrous

The new canCreateRequest method and using isAllowedToCreateRequest in MoneyRequestSelectorPage - it sort of feels like this makes the changes to withReportOrNotFound more unnecessary? but I am technically out of office so may have vacation brain :)

withReportOrNotFound only checks whether the report can be accessed or exists or not. So we need a special to check whether the existing report that is passed from withReportOrNotFound can create a money request or not. The example case is we access the money request by deeplink with reportID is the id of the admin room

The isArchived check in MoneyRequestConfirmPage

This is another case that is introduced in #27113

Removing the useEffect from NewRequestAmountPage - is this because it will never be shown due to the canCreateRequest stuff up above?

Yes canCreateRequest can cover this case and we will display not found page now instead of dismissing the modal

Not a question - does doesRequireReportID or requiresReportID make more sense for our parameter name? isRequireReportID feels strange to me.

Do you think about shouldRequireReportID

dukenv0307 · 2023-10-18T12:28:32Z

@dangrous any thought in my comment above.

dangrous · 2023-10-18T20:17:42Z

Hi! Sorry, still catching up on stuff. Should be able to look at this shortly.

dangrous · 2023-10-19T16:27:43Z

Okay, so apologies for all the questions. I have a couple more clarifications. Your explanations up there made sense though!

So in the new logic:

If isRequireReportID is true, which is the default, the behavior is exactly the same. So that will be the case for all components except MoneyRequestSelectorPage. Is this correct? Do we need to adjust any of the other Money Request flow pages?
When isRequireReportID is false, if there is a reportID in the route, then it goes through the same logic as if isRequireReportID is true. But, it never actually uses the reportID from the route. So wouldn't it always show NotFoundPage?
When isRequireReportID is false, if there is NOT a reportID in the route, then it will just show the Wrapped Component. Which in this case would show the MoneyRequestSelectorPage, which in turn shows the FullPageNotFoundView if there is no report. How does this work if the user IS supposed to see the report? Or is there always props.report except when following an incorrect URL like in the initial issue?
Should isReportIdInParam really be named that, or is it more accurately isReportIDInRoute (route v param)

I do prefer shouldRequireReportID too.

Tests okay, I'm just still struggling to make sure I understand the code. If you could add some comments in - for me and for future developers - that would be great!

dukenv0307 · 2023-10-19T17:05:40Z

If isRequireReportID is true, which is the default, the behavior is exactly the same. So that will be the case for all components except MoneyRequestSelectorPage. Is this correct? Do we need to adjust any of the other Money Request flow pages?

Yes, that will be the case for all components using the HOC now except MoneyRequestSelectorPage. I think we don't need to add the HOC for other money request flow pages because with invalid report or amount is 0, other pages will go back to MoneyRequestSelectorPage page.

When isRequireReportID is false, if there is a reportID in the route, then it goes through the same logic as if isRequireReportID is true. But, it never actually uses the reportID from the route. So wouldn't it always show NotFoundPage?

When isRequireReportID is false, if there is a reportID in the route, the logic will be the same as if isRequireReportID is true, and not found page will be displayed if the reportID is invalid.

When isRequireReportID is false, if there is NOT a reportID in the route, then it will just show the Wrapped Component.

Yes if there is not a reportID in the route, it will just show the Wrapped Component. And in the MoneyRequestSelectorPage, we checked the props.report.reportID is empty, the not found page will not show because the user is creating a money request in global menu.

dukenv0307 · 2023-10-19T17:07:40Z

@dangrous Update the variable, and add some comments.

dangrous

Thanks for the explanation! This looks good - one last variable change to make it a bit clearer and then I think we're good to merge!

src/pages/home/report/withReportOrNotFound.js

Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

dukenv0307 · 2023-10-20T15:34:50Z

@dangrous updated.

dangrous

Sweet!

OSBotify · 2023-10-20T16:14:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:37:15Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:49:27Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 4 commits August 29, 2023 10:19

refactor withReportOrNotFound HOC

67f85bc

add util to check request option

085f3f7

merge main

1b2b4d5

fix lint

6f741fa

dukenv0307 marked this pull request as ready for review September 14, 2023 03:35

dukenv0307 requested a review from a team as a code owner September 14, 2023 03:35

melvin-bot bot requested review from sobitneupane and removed request for a team September 14, 2023 03:35

dukenv0307 added 2 commits September 14, 2023 16:34

refactor HOC in other pages

b3c2f4a

Merge branch 'main' into fix/23755

51a228f

Merge branch 'main' into fix/23755

cb0aaae

merge main

0b0157c

merge main

054d1a6

dukenv0307 mentioned this pull request Sep 28, 2023

[$500] Request Money - The user is able to request money from the Concierge by changing chat ID #28332

Closed

6 tasks

Merge branch 'main' into fix/23755

d4605e7

sobitneupane approved these changes Oct 5, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous October 5, 2023 10:29

fix request money when workspace is deleted

7752d27

merge main

fc4ea70

greg-schroeder mentioned this pull request Oct 18, 2023

[C+ Checklist needs completion] [$1000] Web - App allows user to open request money link of other user and displays amount page twice #23755

Closed

6 tasks

Merge branch 'main' into fix/23755

bc9f426

rename variable

7ae0e53

dangrous requested changes Oct 20, 2023

View reviewed changes

src/pages/home/report/withReportOrNotFound.js Outdated Show resolved Hide resolved

src/pages/home/report/withReportOrNotFound.js Outdated Show resolved Hide resolved

dukenv0307 and others added 2 commits October 20, 2023 22:33

Update src/pages/home/report/withReportOrNotFound.js

bd25fd5

Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

Update src/pages/home/report/withReportOrNotFound.js

21b6b1a

Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

dangrous approved these changes Oct 20, 2023

View reviewed changes

dangrous merged commit bd6a046 into Expensify:main Oct 20, 2023
13 checks passed

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

lanitochka17 mentioned this pull request Oct 21, 2023

[$500] Request - Participant deep link opens Participant page briefly and keyboard opens in Scan #30127

Closed

6 tasks

ishpaul777 mentioned this pull request Oct 22, 2023

[$500] [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Web - Drag and drop feature works on Scan and Distance request money #30148

Closed

6 tasks

situchan mentioned this pull request Oct 24, 2023

[$500] Request money - User A can request money in the workspace expense room using URL, even though only User B should be able to request money #27618

Closed

6 tasks

fedirjh mentioned this pull request Oct 24, 2023

[$1000] Blank page appears instead of Hmm... it's not here page #28183

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web - App allows user to open request money link of other user and displays amount page twice #26149

Web - App allows user to open request money link of other user and displays amount page twice #26149

dukenv0307 commented Aug 29, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

sobitneupane commented Sep 15, 2023

dukenv0307 commented Sep 17, 2023

dukenv0307 commented Sep 19, 2023

sobitneupane commented Sep 19, 2023

dukenv0307 commented Sep 19, 2023 •

edited

Loading

sobitneupane commented Sep 20, 2023

dukenv0307 commented Sep 20, 2023

sobitneupane commented Sep 20, 2023

sobitneupane commented Sep 26, 2023 •

edited

Loading

dukenv0307 commented Sep 26, 2023

dukenv0307 commented Sep 27, 2023

sobitneupane commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023 •

edited

Loading

sobitneupane commented Oct 2, 2023

sobitneupane left a comment

dukenv0307 commented Oct 5, 2023

dangrous commented Oct 5, 2023

dukenv0307 commented Oct 5, 2023

dukenv0307 commented Oct 18, 2023

dangrous commented Oct 18, 2023

dangrous commented Oct 19, 2023

dukenv0307 commented Oct 19, 2023

dukenv0307 commented Oct 19, 2023

dangrous left a comment

dukenv0307 commented Oct 20, 2023

dangrous left a comment

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

Web - App allows user to open request money link of other user and displays amount page twice #26149

Web - App allows user to open request money link of other user and displays amount page twice #26149

Conversation

dukenv0307 commented Aug 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

sobitneupane commented Sep 15, 2023

dukenv0307 commented Sep 17, 2023

dukenv0307 commented Sep 19, 2023

sobitneupane commented Sep 19, 2023

dukenv0307 commented Sep 19, 2023 • edited Loading

sobitneupane commented Sep 20, 2023

dukenv0307 commented Sep 20, 2023

sobitneupane commented Sep 20, 2023

sobitneupane commented Sep 26, 2023 • edited Loading

dukenv0307 commented Sep 26, 2023

dukenv0307 commented Sep 27, 2023

sobitneupane commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023 • edited Loading

sobitneupane commented Oct 2, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

dukenv0307 commented Oct 5, 2023

dangrous commented Oct 5, 2023

dukenv0307 commented Oct 5, 2023

dukenv0307 commented Oct 18, 2023

dangrous commented Oct 18, 2023

dangrous commented Oct 19, 2023

dukenv0307 commented Oct 19, 2023

dukenv0307 commented Oct 19, 2023

dangrous left a comment

Choose a reason for hiding this comment

dukenv0307 commented Oct 20, 2023

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

dukenv0307 commented Aug 29, 2023 •

edited

Loading

dukenv0307 commented Sep 19, 2023 •

edited

Loading

sobitneupane commented Sep 26, 2023 •

edited

Loading

dukenv0307 commented Oct 2, 2023 •

edited

Loading