[HOLD for payment 2023-12-08] [Theme Switching Migration] EnablePayments Batch

[grgia]

Part of #31677

As part of the Theme Switching Project, we need to migrate the following:

• LongTermsForm.js
• CollapsibleSection/index.tsx
• BaseOnfidoWeb.js
• Picker/BasePicker.js
• src/pages/ReimbursementAccount/RequestorStep.js
• src/components/Icon/BankIcons.ts

[koko57]

leaving a comment to be assigned :)

[koko57]

We can sdd these files to this batch:
src/pages/ReimbursementAccount/RequestorStep.js
src/components/Icon/BankIcons.ts

[grgia]

updated description!

[koko57]

@grgia I'll be working on this one

[koko57]

@grgia fontFamily imports should be left as they are now? import fontFamily from '@styles/fontFamily';

[grgia]

cc @chrispader on #31681 (comment)

[koko57]

@grgia @chrispader - similar question for getBankIcon (from BankIcons.ts) - should we also use the styles from the hook? It looks like these styles are not theme-dependent. To use the styles from the hook we would have to pass the styles object to the getBankIcon function (which is used in another util function, so we would have to pass the styles object to it as well). WDYT of this one? Is it worth changing?

[chrispader]

@grgia fontFamily imports should be left as they are now? import fontFamily from '@styles/fontFamily';

As far as i see it, nothing changes for the fonts based on the theme :)

[chrispader]

@grgia @chrispader - similar question for getBankIcon (from BankIcons.ts) - should we also use the styles from the hook? It looks like these styles are not theme-dependent. To use the styles from the hook we would have to pass the styles object to the getBankIcon function (which is used in another util function, so we would have to pass the styles object to it as well). WDYT of this one? Is it worth changing?

Let's pass the themeStyles to the hook anyway. Right now, all of the styles are defined in one big theme-dependent styles object in styles.js. For now, we want to aim for consistency so we only "allow" using styles though useThemeStyles.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat/31681 theme switching migration enablepayments batch #31913

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)

[melvin-bot]

@koko57, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@koko57, @grgia Huh... This is 4 days overdue. Who can take care of this?