Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] Implement new Video Player components #32770

Closed
8 tasks done
francoisl opened this issue Dec 9, 2023 · 22 comments
Closed
8 tasks done

[CRITICAL] Implement new Video Player components #32770

francoisl opened this issue Dec 9, 2023 · 22 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@francoisl
Copy link
Contributor

francoisl commented Dec 9, 2023

Part of the NewDot Video Player project

Main issue: #20471
Doc section: https://docs.google.com/document/d/1Fh5Nu3D0-VW7xuV9Qc-OWWZl3-W5azx7Rr1lzNw4UGo/edit#heading=h.py28s16nvvga
Project: https://github.com/orgs/Expensify/projects/109

Feature Description

  1. Implement the new components that will be used to play videos in NewDot:
  • <ProgressBar />
  • <VolumeButton />
  • <VideoPlayerControls />
  • <VideoPlayer />
  • <VideoRenderer />
  • <AttachmentViewVideo />
  1. Introduce Context to manage player state
  • PlaybackContext (doc)
  • VideoVolumeContext (doc)
  1. Maintain accessibility
  • Add keyboard tab support for switching focus between elements (doc)
  • Add accessibilityLabels and accessibilityRoles for components

cc @Skalakid

@francoisl francoisl added the NewFeature Something to build that is a new item. label Dec 9, 2023
Copy link

melvin-bot bot commented Dec 9, 2023

@Skalakid
Copy link
Contributor

Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue

@JmillsExpensify
Copy link

Updates in Slack

@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@francoisl
Copy link
Contributor Author

Latest Slack update available here.

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2024
@kowczarz
Copy link
Contributor

kowczarz commented Jan 8, 2024

Hey, since Michał will have to focus on different issues I'm taking over this task.

@francoisl
Copy link
Contributor Author

Last week's update is here in Slack. @kowczarz is working on this and has been familiarizing with Michał's WIP PR.

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@francoisl francoisl added the Reviewing Has a PR in review label Jan 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2024
@francoisl
Copy link
Contributor Author

Not overdue, the main PR is still in review. We just merged #35249 which was also needed for the video player PR.

@francoisl francoisl mentioned this issue Feb 16, 2024
58 tasks
@francoisl
Copy link
Contributor Author

The video player is on staging now.
We're centralizing issues and follow-up tasks here.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 20, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@trjExpensify
Copy link
Contributor

👋 As discussed here, moving this into #vip-vsb as wave9 gets deprecated. Not entirely sure there's a bunch left to do here, but given that wave9 is closing, I didn't want to leave it nowhere in limbo. Thanks!

@francoisl
Copy link
Contributor Author

Ah, this is all done and deployed, the automation didn't work at closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Status: CRITICAL
Status: CRITICAL
Development

No branches or pull requests

5 participants