[Tracking] Video Player Launch

[francoisl]

Tracking issue for the Video Player launch bugs and follow-up tasks

Critical

• https://github.com/Expensify/Expensify/issues/370787 - @francoisl (internal)
• https://github.com/Expensify/Expensify/issues/371232 - @francoisl (internal)
• https://github.com/Expensify/Expensify/issues/370796 - @francoisl (internal)

Known issues for polish

• [Video Player] Don't show the Edit quick action menu option for video & show Download option #36627 - @francoisl (internal)
  • Editing the comment causes the video player to no longer render. We should hide the edit option, similar to what we do with images at the moment

Follow-up changes / V2

High

• Add support for auto-playing videos

Medium

Low

• Migrate new JS files to TS - see issues linked in this comment
  We agreed to merge the PR without migrating all new files to TS, let's migrate them when possible. New JS files:
  • src/components/Attachments/AttachmentView/AttachmentViewVideo/index.js
  • src/components/VideoPlayer/BaseVideoPlayer.js
  • src/components/VideoPlayer/IconButton.js
  • src/components/VideoPlayer/VideoPlayerControls/ProgressBar/index.js
  • src/components/VideoPlayer/VideoPlayerControls/VolumeButton/index.js
  • src/components/VideoPlayer/VideoPlayerControls/index.js
  • src/components/VideoPlayer/index.js
  • src/components/VideoPlayer/index.native.js
  • src/components/VideoPlayer/propTypes.js
  • src/components/VideoPlayerContexts/PlaybackContext.js
  • src/components/VideoPlayerContexts/VideoPopoverMenuContext.js
  • src/components/VideoPlayerContexts/VolumeContext.js
  • src/components/VideoPlayerPreview/VideoPlayerThumbnail.js
  • src/components/VideoPlayerPreview/index.js
  • src/components/VideoPopoverMenu/index.js
• Add support for Picture-in-Picture (PiP)

---

cc @Skalakid @kowczarz

[SzymczakJ]

@francoisl can we create task for TS migration? VideoPlayer is blocking my migration task. I could also start to work on this right away to merge both tasks ASAP.

[hayata-suenaga]

ah sorry I'm creating TS migration issues now 🙇

[hayata-suenaga]

Created TS migration issues for JS files

• [hold for payment 2024-04-17] [$250] [TS migration] Migrate VideoPlayer component files to TypeScript #36722
• [$250] [TS migration] Migrate VideoPlayerControls and VideoPopoverMenu component files to TypeScript #36723
• [HOLD for payment 2024-03-22] [$250] [TS migration] Migrate VideoPlayerContexts component files to TypeScript #36724
• [$250] [TS migration] Migrate VideoPlayerPreview component files to TypeScript #36725

cc: @SzymczakJ

[stephanieelliott]

Noting this video player bug since it doesn't look like it's being tracked on this issue: iOS Safari - Video file preview not displayed after selecting video from device gallery #36832

Not sure if you are still tracking followup bugs or of those should be distributed out, so I've added it to #vip-vsb!

[francoisl]

Not overdue, all the main follow-up issues are already done or assigned and being worked on.

[francoisl]

Going to close this, all the required TS migrations and follow-up tasks are already tracked in issues.