Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-22] [$250] [TS migration] Migrate VideoPlayerContexts component files to TypeScript #36724

Closed
hayata-suenaga opened this issue Feb 16, 2024 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 16, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files related to the VideoPlayerContexts component

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01981a2129abb4828c
  • Upwork Job ID: 1758559484183658496
  • Last Price Increase: 2024-02-16
@hayata-suenaga hayata-suenaga added External Added to denote the issue can be worked on by a contributor Daily KSv2 Typescript Migration labels Feb 16, 2024
@hayata-suenaga hayata-suenaga self-assigned this Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01981a2129abb4828c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@ghost
Copy link

ghost commented Feb 16, 2024

Dibs

@MahmudjonToraqulov
Copy link
Contributor

Would like to work on it.

@rayane-djouah
Copy link
Contributor

dips

@ZhenjaHorbach
Copy link
Contributor

I can work on it
And I don't have others TS issues assigned to me

@EnderKilledYou
Copy link

Proposal

Update the Video player component to type script following the style guide.

Please re-state the problem that we are trying to solve in this issue.

We want uniform language throughout the app.

What is the root cause of that problem?

Files are not in type script

What changes do you think we should make in order to solve the problem?

Change them to typescript

What alternative solutions did you explore? (Optional)

Maybe changing them to blazor.

@Koustubh-lapate
Copy link

I am Koustubh, a full stack developer. I’d like to work on this job.

@kowczarz
Copy link
Contributor

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this issue.

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Feb 19, 2024
@suneox
Copy link
Contributor

suneox commented Feb 19, 2024

I don't have any other TS migration assigned so would like to work on this ticket

@kowczarz
Copy link
Contributor

Hey @hayata-suenaga, I'm leaving the Expensify-SWM team for now and @smelaa will handle this task.

@smelaa
Copy link
Contributor

smelaa commented Feb 20, 2024

Hello! I'm Aleksandra Smela from Software Mansion, the expert agency and I would like to work on this issue.

Copy link

melvin-bot bot commented Feb 20, 2024

📣 @smelaa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@hayata-suenaga hayata-suenaga assigned smelaa and unassigned kowczarz Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

Copy link

melvin-bot bot commented Feb 23, 2024

@eVoloshchak, @hayata-suenaga, @smelaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor Author

The BZ member will need to manually hire smelaa for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

No need to hire smelaa. They're from Software Mansion, one of the expert agencies.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 23, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

@eVoloshchak, @hayata-suenaga, @smelaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor Author

@smelaa please mark the PR ready for review once it's ready 🙇

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Feb 26, 2024
@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

@hayata-suenaga
Copy link
Contributor Author

@bfitzexpensify

needs payment for @eVoloshchak who is a C+ who reviewed the TypeScript migration PR. The PR author is an expert agency engineer and no need for payment

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate VideoPlayerContexts component files to TypeScript [HOLD for payment 2024-03-22] [$250] [TS migration] Migrate VideoPlayerContexts component files to TypeScript Mar 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @eVoloshchak requires payment through NewDot Manual Requests
  • @smelaa does not require payment (Contractor)

Copy link

melvin-bot bot commented Mar 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@eVoloshchak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@bfitzexpensify
Copy link
Contributor

Payment summary:

@eVoloshchak to be paid $250 via manual request
@smelaa does not require payment (contractor)

@JmillsExpensify
Copy link

$250 approved for @eVoloshchak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests