Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Room -Transition between Workspaces and Room is sluggish #33102

Closed
3 of 6 tasks
lanitochka17 opened this issue Dec 14, 2023 · 6 comments
Closed
3 of 6 tasks

Web - Room -Transition between Workspaces and Room is sluggish #33102

lanitochka17 opened this issue Dec 14, 2023 · 6 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is not a part of any workspace

  1. Click FAB > Start chat
  2. Go to Room
  3. Click Learn more
  4. Click back button

Expected Result:

The transition between Workspaces and Room is smooth

Actual Result:

The transition between Workspaces and Room is sluggish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313363_1702574548215.bandicam_2023-12-15_00-08-12-800__2_.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcochavezf
Copy link
Contributor

I will be afk for one hour aprox, and will continue testing when I come back

@abzokhattab
Copy link
Contributor

abzokhattab commented Dec 14, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transitions between Tabs become laggy after a few clicks

What is the root cause of that problem?

In the new chat selector page we use the TabSelector component as a prop inside the OynxTabNavigator component

This TabSelector gets rerendered everytime we click on a tab so after some clicks, the transitions become very slow.

This issue affects all components that use the TabSelector

  1. NewChatSelectorPage
  2. MoneyRequestSelectorPage
  3. IOURequestStartPage

What changes do you think we should make in order to solve the problem?

we need to use React.memo on the TabSelectorItem:

to do so we need to add this line:

    const MemoizedTabSelectorItem = React.memo(TabSelectorItem);

and change this


to

<MemoizedTabSelectorItem

POC

Screen.Recording.2023-12-14.at.11.08.39.PM.mov

@situchan
Copy link
Contributor

The root cause already exists in production so I don't think this is blocker.
Dupe of #31190

@marcochavezf
Copy link
Contributor

Oh interesting, thanks @situchan, after reviewing the other issue I agree this is a dupe and not a blocker. I will close it out in favor of #31190

@marcochavezf marcochavezf removed the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants