Deploy Checklist: New Expensify 2023-12-14

[github-actions]

Release Version: 1.4.13-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Theme switching: Going Live! (Add preferences menu entry for ThemePage) #21669
• Status clear after #24620
• Add new blocking view for new room page #30051
• Implement new UpdateMoneyRequestDate API endpoint #30737
• Popover Fixes #30882
• [TS Migration] Migrate CopyTextToClipboard.js to TypeScript #31486
• Fix/30921: No error message when editing a chat #31769
• Update @react-navigation/native version #32087
• Fix/32230: Update recently used tag and category when editing request #32467
• fix: hide pending deleted actions #32474
• [TS Migration] Migrate '[Remaining Group 2]' hook to TypeScript #32484
• Removed Concierge button from HelpDot sidebar #32526
• [TS migration] Migrate 'HeaderGap' component to TypeScript #32567
• [CP Staging] Fix issues with scrollbar and status bar color #32672
• Re-structure styles and theme switching components #32679
• [No QA] Use vanilla setupGitForOSBotify action in createNewVersion.yml #32848
• Fix/19642 report screen unexpected scroll #32930
• fix: referral link #32950
• Update Referral-Program.md #32951
• feat: add a new permission for reportFields #32957
• [Snyk] Upgrade electron-serve from 1.1.0 to 1.2.0 #32974
• Fix Wallet Cardholder Name in Light Mode #32989
• [NoQA] Fix Lint on Main: ignore style generators files in findUnusedKeys.sh #33017
• Use Paid in money request preview #33020
• Use plural in next steps to match oldDot #33023
• [CPStaging] Fix Use Device Settings on IOS and Android #33094
• [CP Staging] Fix Page Colors Keys in Light Mode (Status Page, Wallet Root) #33100
• [CP Staging] fix: bank account flow - inscription text style #33141
• [CP Staging] fix: Retain hidden participants when creating an IOU request #33156
• fix: Revert the use of SET operation when updating Money Requests #33174
• [CP Staging] Fix Sign In Modal Header/"Join the Discussion" Colors #33181
• Picker style fix #33194

Deploy Blockers:

• [HOLD for payment 2023-12-26] [$500] Web - Chat - Workspace avatar is greyed out in the conversation report preview #32984
• [$500] Thread - App crashes when leaving thread #33009
• [HOLD for payment 2024-02-05] [$500] IOU - "Total will update when you're back online" is missing on IOU request with foreign currency #33073
• [Theme Switching] Chat - All tooltips are dark in light theme #33086
• [Theme Switching] Status - The status tab doesn't change the theme in Light mode #33087
• [Theme Switching] 🐛 🎨 Light theme - "Splash Page" animation is in dark theme #33092
• Status - Error when saving the custom time at 00:00 am #33093
• [Hold for Payment 2024-01-16] [Theme Switching] 🎨 Light theme - "+" icon in distance tab is white on white background #33095
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Expense - App crashes when saving expense date twice in offline mode #33098
• [$500] App missing parameter triggers backend error #33099
• [$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101
• Web - Room -Transition between Workspaces and Room is sluggish #33102
• Web - Expense - Fields are blank and header shows $0.00 request when changing date #33103
• [Theme Switching] 🐛 Light theme - Icon for "Loading Distance report" is showing in dark theme #33104
• [Theme Switching] 🐛 Help - Help page is in dart mode. #33105
• [HOLD for payment 2023-12-28] [Theme Switching] 🐛 Light theme - Transition icon in Add bank account flow is showing as Dark theme #33106
• [$500] Web - When a user changes their profile status, the app brings you to the end of the conversation. #33110
• [HOLD for payment 2023-12-28] [Theme Switching] 🐛 - Animation on 2FA confirmation has a dark background when light theme applied #33116
• [HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard #33118
• [Theme Switching] 🐛 Android - Download confirmation window still dark in light theme #33120
• [Theme Switching] Web - Dark mode displayed after logged out #33121
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 Wallet - Open in app banner is dark themed on Wallet page even if the app is in light mode #33122
• [Theme Switching] 🐛 Android - After applying light theme and opening IOU or task device status bar barely seen #33126
• [$500] Status - Error message & emoji status remains when clear status timer has elapsed #33128
• [$500] Chat – “Hmm…It’s not here” appears when open Distance request in RHP and navigate via link #33132
• [HOLD for payment 2024-01-25] [$500] BA - Animation in "One moment" page is smaller than other environments #33134
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Connect Bank account - Inscription Additional beneficial owner is invisible on the page of beneficial owners #33135
• [HOLD for payment 2023-12-28][$500][Theme Switching] 🐛 Android - Track distance - The inscription in the pop-up window is hardly visible in light mode #33136
• [Theme Switching] 🐛 Android - Distance - Mapbox remains in dark mode when the app is in light mode #33137
• [Theme Switching] 🐛 Android - Scan - Capture error and camera access pop-ups are not in dark mode #33138
• Status - Inappropriate error message when setting custom time in the past #33139
• [HOLD for payment 2024-01-11] [$500] Status - Highlighting minutes and pressing Back key does not reset it to 00 #33143
• [HOLD for payment 2024-01-17] [$500] Theme - Workspace counter in Settings is white and has low legibility #33146
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [$500] Web - IOU – Unable to create IOU with non-existing user via 1:1 conversation #33151
• [HOLD for payment 2024-01-17] [$500] Wallet - Extra top padding on each field in Additional details page #33154
• [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] Theme - "Join the discussion" is illegible and inconsistency in sign-in modal theme in public room #33159
• [Hold, Testing][$500] Theme - Theme is always reset to "Use Device Settings" after relogin #33160
• [hold for payment 2024-04-17] - Avatar placeholder remains in dark mode when app is in light mode #33161
• [HOLD for payment 2024-01-09] [$500] Theme - Skeleton placeholder in LHN does not switch theme when device theme is switched #33163
• [Theme Switching] 🐛 Android - Scan - "Wrong attachment" pop-up is not in light mode and incorrect 'filetype' spelling #33164
• Status - In the time section, pressing button 2 displays 8 #33166
• [HOLD for payment 2024-01-31] [$500] Settings - On clear after never, status save does not work #33168

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

#32984 and #33009 were from the last checklist, but showed up as I forgot to remove the label. Checked them both off

[Julesssss]

#33073 is not a blocker

[rlinoz]

Demoting and checking off #33092

[grgia]

Demoting #33095

[francoisl]

#33103 not a blocker, demoting and checking off.

[grgia]

Demoting #33106

[kavimuru]

Regression is 30% progress
#30737 failing with #33098

[grgia]

demoting #33116
demoting #33120
closed #33121

[jasperhuangg]

Checking off #33134 NAB

[grgia]

I'll be able to help with the remaining theme-related blockers after a break tonight- I've fixed all the ones that were definitely blockers and demoted ones that are not and I'll try to help with the two newest ones in a bit!

[jasperhuangg]

#33138 NAB

[jasperhuangg]

#33139 NAB

[Julesssss]

#33118 is not a blocker

[Julesssss]

#33132 is not a blocker, checking it off

[Julesssss]

Resolved #33091 and #33122 with #33100

[Julesssss]

#33143 is not a blocker

[Julesssss]

#33135 was fixed by #33141. But I will leave it to QA to test and check it off

[Julesssss]

#33146 is not a blocker, checked off

[jasperhuangg]

Checking off #33135 CP'd a fix

[kavimuru]

Regression is completed.
unchecked PR: #30737 failing with #33098

Open Blockers:
#33099, #33128, #33136, #33151, #33159, #33160, #33161, #33163, #33166 and #33164

[Julesssss]

#33160 shouldn't block deploy, checking off

[Julesssss]

#33161 shouldn't block the deploy, checking off

[Julesssss]

#33163 shouldn't block deploy, checking off

[Julesssss]

Checking off #33151 and #33156 after I verified the fix on staging

[Julesssss]

Checking off #33166 as it is expected behaviour

[Julesssss]

Checking off #33164 as it is not a blocker

[roryabraham]

#33136 should be fixed by #33194 in 1.4.13-6. Please retest once the deploy completes

Update: Deploy completed. Please retest #33136 ASAP

[mvtglobally]

retested. Updated the issue

[roryabraham]

#33136 is solved to the degree we intend to solve it in this release, checking it off

[jasperhuangg]

Checking off #33128, BE issue

[jasperhuangg]

Checking off #33159

[jasperhuangg]

Summary of remaining blockers here

[jasperhuangg]

Checking off #33098

[kavimuru]

#33174 failing with #33248 repro in PROD, checking it off.

[jasperhuangg]

Checking off #33110, NAB

[jasperhuangg]

Checking off #33168, NAB

[jasperhuangg]

I just QA'd #30737 myself, and it seems to be working as expected, checking it off

[jasperhuangg]

[os-botify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jasperhuangg]