[Theme Switching] 🐛 Android - Distance - Mapbox remains in dark mode when the app is in light mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.13-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: App is in light mode

1. Launch New Expensify app
2. Tap FAB icon > Request money
3. Go to Distance
4. Tap on the mapbox info icon

Expected Result:

The mapbox info pop-up is in light mode

Actual Result:

The mapbox info pop-up remains in dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

I don't think we need to block deploy on this, gonna remove the label

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[jasperhuangg]

Looping in Design, are we expecting this modal to also be in a light theme? cc @dannymcclain

[jasperhuangg]

This seems like a similar design problem to #33120 (comment)

cc @dubielzyk-expensify @grgia

[dannymcclain]

@jasperhuangg definitely feels similar to that issue you linked. I think if we can update this for light mode, that would be ideal. But if for some reason we can't/won't/don't want to, I don't think it's the end of the world since this feels almost more like "mapbox modal" than it does Expensify UI.

[dubielzyk-expensify]

Yeah, if not, I think we should just revert to using system defaults here so that the OS can take care of the colors. Given this is a mapbox specific thing, I think that's fine

[dannymcclain]

Based on this thread in Slack, it looks like we've reached a decision to not add any custom styling to native popups and let the OS handle the theming. @grgia that sound right to you?

[melvin-bot]

@dannymcclain, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@dannymcclain, @jasperhuangg Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@dannymcclain, @jasperhuangg 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@dannymcclain, @jasperhuangg 12 days overdue now... This issue's end is nigh!

[jasperhuangg]

Bump @grgia on this comment

[melvin-bot]

@dannymcclain, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jasperhuangg]

Bumped @grgia via DM

[grgia]

Yes that sounds correct, we can close this as I have a master issue for this here #33235

[dannymcclain]

Closing per Georgia's comment! 🌂