-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Theme Switching] 🐛 Light theme - Icon for "Loading Distance report" is showing in dark theme #33104
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @neil-marcellini ( |
I don't really think this is a bug, because I don't think we intended for the style to change in light mode. I know that I discussed with the design team about whether we needed to change the style for distance eReceipts in light mode, and the decision was that the style should always be the same. Assigning a designer for their input. |
Triggered auto assignment to @dannymcclain ( |
Totally agree @neil-marcellini. That was my first thought when I saw this come through. cc @Expensify/design in case they have a different opinion. |
Ok cool, then I'm going to close this issue. We can re-open it later if someone disagrees and thinks this is a problem. |
EReceipt color is not a bug, agree with closing this |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User expects the theme to be Light like the rest of the app
Actual Result:
The theme is dark
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6313399_1702576279008.Preview_for_Distance_request_shows_as_Dark_theme.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: