Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme Switching] 🐛 Light theme - Icon for "Loading Distance report" is showing in dark theme #33104

Closed
6 tasks done
lanitochka17 opened this issue Dec 14, 2023 · 7 comments

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Access staging.new.expensify.com
  2. Sign into a valid account
  3. Put the Site to "Light mode" in preferences
  4. Create a distance report
  5. Click on the IOU before the image of the map loads

Expected Result:

User expects the theme to be Light like the rest of the app

Actual Result:

The theme is dark

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313399_1702576279008.Preview_for_Distance_request_shows_as_Dark_theme.mp4

Bug6313399_1702576278994!Dark_theme

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

I don't really think this is a bug, because I don't think we intended for the style to change in light mode. I know that I discussed with the design team about whether we needed to change the style for distance eReceipts in light mode, and the decision was that the style should always be the same. Assigning a designer for their input.

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

@dannymcclain
Copy link
Contributor

Totally agree @neil-marcellini. That was my first thought when I saw this come through. cc @Expensify/design in case they have a different opinion.

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Dec 14, 2023

Ok cool, then I'm going to close this issue. We can re-open it later if someone disagrees and thinks this is a problem.

@neil-marcellini neil-marcellini closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

EReceipt color is not a bug, agree with closing this

@grgia grgia added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 14, 2023
@grgia grgia changed the title Light theme - Icon for "Loading Distance report" is showing in dark theme [Theme Switching] 🐛 Light theme - Icon for "Loading Distance report" is showing in dark theme Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants