Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Assign task - Can't find existing user (assign task) #33611

Closed
4 of 6 tasks
kbecciv opened this issue Dec 26, 2023 · 11 comments
Closed
4 of 6 tasks

[$500] Assign task - Can't find existing user (assign task) #33611

kbecciv opened this issue Dec 26, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Dec 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33347

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an expensifail account
  3. Open any chat
  4. Open chat menu and select "Assign task"
  5. Add title and press "Next"
  6. Press "Assignee"
  7. Type in "tomasz.misiukiewicz@callstack.com"

Expected Result:

User should be able to find an existing user.

Actual Result:

User cannot find tomasz.misiukiewicz@callstack.com.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326326_1703615106160.bandicam_2023-12-26_12-44-07-879.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ef63cf1654af54ad
  • Upwork Job ID: 1739719702996258816
  • Last Price Increase: 2024-01-02
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ef63cf1654af54ad

@melvin-bot melvin-bot bot changed the title Assign task - Can't find existing user (assign task) [$500] Assign task - Can't find existing user (assign task) Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@adriancova
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Existing users are not listed as an option for assigning a task.

What is the root cause of that problem?

In the component TaskAssigneeSelectorModal the call to OptionsListUtils.getFilteredOptions is done with the parameter canInviteUser set as false. This translates to the list of users available being limited to only contacts and recent.

What changes do you think we should make in order to solve the problem?

Change the parameter to true, this will update the behavior of assigning tasks to be the same as start chat, request money and send money. Where you can select already existing users even if they're not in your recent or contact lists.

What alternative solutions did you explore? (Optional)

NA

@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
@bfitzexpensify
Copy link
Contributor

How does the proposal in #33611 (comment) look @ntdiary?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 29, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@ntdiary, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bfitzexpensify
Copy link
Contributor

Bump on review here when you get a chance @ntdiary - thanks!

@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2024
@ntdiary
Copy link
Contributor

ntdiary commented Jan 2, 2024

Bump on review here when you get a chance @ntdiary - thanks!

@bfitzexpensify, ah, sorry. I investigated a few days ago but forgot to update. In PR #25806, we intentionally disallowed assigning tasks to accounts that you have never chatted with. So, I think it's fine to just close this issue. :)

Copy link

melvin-bot bot commented Jan 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@bfitzexpensify
Copy link
Contributor

Cool, agreed, closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants