[$500] [HOLD for payment 2024-01-17] Merchant for P2P is showing as empty

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.20-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation:

Action Performed:

Break down in numbered steps

1. Create money request with another person
2. Set amount
3. Click Show more
4. Click Merchant
5. Click Save with empty merchant

Expected Result:

Describe what you think should've happened

User should be taken back to the confirmation list

Actual Result:

Describe what actually happened

The Merchant is showing as required which is not correct for IOU report, the merchant is only required for expense requests (so when the isPolicyExpenseChat is true)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Click back

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2023-12-29.at.23.10.50.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b6a6202b3a982132
• Upwork Job ID: 1748072366986219520
• Last Price Increase: 2024-01-18

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @koko57 @waterim This is one follow up we need to handle from our PR to make the merchant required

[melvin-bot]

@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[koko57]

@mountiny So here the problem was that we were validating if the merchant is empty no matter if it was p2p or workspace IOU. I've added a simple check to make sure to only validate when the merchant is required.

I also found a typo(?) in the route name:

let me know if I should fix it this PR 🙂

[mountiny]

Yep we can fix that in this pr too thbaks

[koko57]

ok, thanks! so I will add this fix and open the PR

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

I can take this on as wave6 and i have worked with the previous iterations of this update

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: make merchant not required for p2p #33844

If no regressions arise, payment will be issued on 2024-01-17. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[mountiny]

@allroundexperts was this a regression from a PR you have worked on or should there be a request from you on this one? Can I close :D

[mountiny]

$500 to @allroundexperts

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b6a6202b3a982132

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[bfitzexpensify]

Payment summary:

$500 to be paid to @allroundexperts to be paid via manual request.

[bfitzexpensify]

Wait, I might have closed this prematurely - @mountiny, do we need to complete the BZ checklist here?

[mountiny]

I dont think so it was a part of a bigger feature update, the pr author knows about this

Regression tests will be covered holistically too i think

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.