[HOLD for payment 2024-01-17] [HOLD for payment 2024-01-18] Chat - The app crashes if I open an image attachment in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open a conversation
2. Send an image attachment
3. Go offline
4. Tap on the attachment

Expected Result:

The app shouldn't crash

Actual Result:

The app crashes if I open an image attachment in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333328_1704473177929.az_recorder_20240105_101313.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

I am not able to reproduce on main. Tested on android physical device

[0xmiros]

@lanitochka17 can you please share crash log?

[lanitochka17]

@0xmiroslav Made a request to the tester

[lanitochka17]

@0xmiroslav
log.txt

[NikkiWines]

I can't reproduce this on staging (iOS 1.4.22.0 and 1.4.22.1) or on dev 🤔

RPReplay_Final1704495691.mov

[situchan]

Checking crash log, this happens on pdf attachment and dupe of #34017

Here's context: #34017 (comment)

@NikkiWines I am available now to raise PR

[NikkiWines]

oh nice, good catch on the dupe @situchan. It looks like we updated to 6.7.4 because of another issue related to the app crashing with PDFs (#33561) so I'm not sure downgrading is in our best interest 🤔

I guess it depends on which scenario we think would be more common:
a. User viewing a PDF file in offline mode
b. User uploading a PDfs with formulas/maths symbols

[situchan]

#29743 is android only issue and happened on specific pdfs.
#34047 is native (android/iOS) issue and happens on all pdfs.
So I believe #34047 is more common scenario

[marcaaron]

hmm I am kind of confused actually and questioning the relatedness now. Tester is not using PDFs are they?

[situchan]

The clear repro step is #34017

[marcaaron]

This issue does not reference anything about a PDF.

[situchan]

1. Go to the chat where you have sent the PDF file
2. Send any image
3. Tap on the image preview
4. Tap on the back button

I believe @lanitochka17 missed Step 1 in repro step.
I checked crash log in #34047 (comment) and crash happened on pdf.

[marcaaron]

Not seeing it. How did you determine that?

[situchan]

Not seeing it. How did you determine that?

[situchan]

As no one is able to reproduce, I think we can ask QA team test staging build again after fixing pdf crash.

[marcaaron]

Nah, I just reproduced on Android with a PDF. They are the same 👍👍

[marcaaron]

I guess it depends on which scenario we think would be more common:
a. User viewing a PDF file in offline mode
b. User uploading a PDfs with formulas/maths symbols

Maybe one of these:

1. Remove the blocker and wait for the upstream fix.
2. Don't try to load any PDFs if we are offline. Better than a crash.

[situchan]

Don't try to load any PDFs if we are offline. Better than a crash.

This happens even when online.
#34017 which was closed as dupe has repro step in online mode

[situchan]

online.test.mov

[NikkiWines]

Updating the labels for this one so we don't forget to issue payment

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Android-Attachments-App crashes on uploading specific PDF" #34078

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

Hm, what's due here? Is this the PR that @situchan should be paid for? #34078

[situchan]

yes

[puneetlath]

And how much is due? $250 since this was a straight revert? Or something else?

[situchan]

I am not sure if this case applies here.

Though solution was straight revert, there was an effort to reproduce and find the root cause.

[puneetlath]

Ok sounds good, thanks for the link.

Payment summary:

• $500 @situchan for finding root cause and fixing issue. Offer here: https://www.upwork.com/nx/wm/offer/100583192

Please ping me on the issue when you've accepted.

[situchan]

Accepted thanks

[puneetlath]

Paid. Thanks everyone!