[$500] Split - App crashes when opening split preview in archived workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat.
2. Create a manual split.
3. Delete the workspace.
4. Return to the workspace chat.
5. Click on the split preview.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354999_1706207861404.20240125_235148__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc3eb6e0c42b3468
• Upwork Job ID: 1750598490050453504
• Last Price Increase: 2024-01-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dc3eb6e0c42b3468

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split - App crashes when opening split preview in archived workspace chat

What is the root cause of that problem?

When we delete a workspace, we remove the policy from the collection as a result we cannot access it
And in this component we have an incorrect condition without an availability check isTaxTrackingEnabled in the policy

As result, we have an undefined for policy and then get error

App/src/components/MoneyRequestConfirmationList.js

Line 252 in 0d0b0a8

const shouldShowTax = props.isPolicyExpenseChat && props.policy.isTaxTrackingEnabled;

What changes do you think we should make in order to solve the problem?

To fix this issue we can update conditions like
For example

const shouldShowTax = props.isPolicyExpenseChat && props.policy && props.policy.isTaxTrackingEnabled;

App/src/components/MoneyRequestConfirmationList.js

Line 252 in 0d0b0a8

const shouldShowTax = props.isPolicyExpenseChat && props.policy.isTaxTrackingEnabled;

Or we can use lodash or something else

Similar condition we have for MoneyTemporaryForRefactorRequestConfirmationList

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@stephanieelliott, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hey @alitoshmatov looks like we have a proposal ready here, can you please review?

[alitoshmatov]

@ZhenjaHorbach Thank you for your proposal, your RCA is correct. The solution is straightforward and on point.

[alitoshmatov]

We can go with @ZhenjaHorbach ' proposal.
@ZhenjaHorbach just make sure we are covering all similar cases for deleted policy

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mkhutornyi]

#34072 should have handled this but they missed this as deprecated component.

But will be fixed in #29107

[alitoshmatov]

Great, thank you @mkhutornyi .

Then we can close this issue or put it on hold

[ZhenjaHorbach]

In fact, this problem is related to the crash
And the deletion ticket has not even been created yet and it is not known when this will happen