[$500] Connect BA modal is not displayed when trying to pay with Expensify in DM chat

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #32959
Version Number: v1.4.33-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: Account A and account B must have USD as the default currency.

1. As user A, create a money request with account B in DM chat.
2. As user B, go to report and click on "Pay with Expensify".
3. Select "Business bank account".

Expected Result:

The Connect BA modal should appear.

Actual Result:

The Connect BA modal is not displayed, error page is displayed instead.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360364_1706582707418.bandicam_2024-01-29_20-17-57-137.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a3801ea0661a1ba
• Upwork Job ID: 1752271356590907392
• Last Price Increase: 2024-01-30
• Automatic offers:
• shubham1206agra | Reviewer | 28147322
• bernhardoj | Contributor | 28147323

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a3801ea0661a1ba

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selecting a business bank account option opens a bank account page with a not found view.

What is the root cause of that problem?

This happens after #33691 where we return early if the email or account ID is empty.

App/src/libs/actions/Policy.ts

Lines 1563 to 1564 in b4fe0c8

	const employeeAccountID = iouReport.ownerAccountID;
	const employeeEmail = iouReport.ownerEmail;

App/src/libs/actions/Policy.ts

Lines 1584 to 1586 in b4fe0c8

	if (!employeeAccountID || !employeeEmail) {
	return;
	}

The value from createWorkspaceFromIOUPayment is used as the policy ID and because we return early. the value is empty.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 128 to 131 in b4fe0c8

	const policyID = Policy.createWorkspaceFromIOUPayment(iouReport);
	// Navigate to the bank account set up flow for this specific policy
	Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('', policyID));

In our case, the email is empty because the IOU report doesn't have ownerEmail but only ownerAccountID. It's been like that for a long time. (ref)

What changes do you think we should make in order to solve the problem?

Default the email value to an empty string (and don't return early) or we can get the email from personal details login.

const employeeEmail = allPersonalDetails[employeeAccountID];

or potentially remove the usage of the email?

[lschurr]

@shubham1206agra - Could you review this one?

[shubham1206agra]

@lschurr I am just figuring out a way to test the proposal correctly (Finding out how to set USD as default currency).

[lschurr]

Any update on this one @shubham1206agra?

[shubham1206agra]

I was busy with some other issues of higher priority. I just need to set up a VPN here to test the USD flow.

[shubham1206agra]

@bernhardoj's proposal works fine.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @shubham1206agra

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @lschurr, @bernhardoj, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[shubham1206agra]

@cead22 @lschurr Can someone start payment process here?

[lschurr]

Thanks for the bump @shubham1206agra! It looks like the automation didn't work to prompt payments.

I just sent you a new offer @shubham1206agra - https://www.upwork.com/nx/wm/offer/new/1028761871?team=8577561

[lschurr]

Payment summary:

• Contributor+: @shubham1206agra $500 (paid in Upwork)
• Contributor: @bernhardoj $500 (paid in Upwork)

[shubham1206agra]

@lschurr I have discussed internally here. You can close this issue after payment to @bernhardoj, as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I still need to be paid.

[lschurr]

Sounds good. I updated the payment summary and will close for now.

[shubham1206agra]

@lschurr You can process payment here now.

[lschurr]

Great, paid!