[Pay 2024-03-06][$500] [CRITICAL] Backwards Compatibility: Disabled tag is not displayed in the list as selected

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.37-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Employee made an IOU request with a tag in WS chat. Tag is disabled after that by WS admin in OD.

1. Employee in ND: click on IOU request to open request details.
2. Click on the tag field

Expected Result:

The disabled tag is displayed in the list as selected

Actual Result:

The disabled tag is not displayed in the list as selected

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6369435_1707232600528.bandicam_2024-02-06_17-02-45-498.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d431d3f18048470e
• Upwork Job ID: 1757799767331749888
• Last Price Increase: 2024-02-20
• Automatic offers:
• DylanDylann | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We think that it will be under the wave [#wave6-collect-submitters]
cc @greg-schroeder

[eucool]

seems like a BE issue as the backend will not send the disabled tag to the FE

[marcaaron]

Reproducible in production?: n

@m-natarajan can you give some more context about why this issue was created and how we deemed it to be a deploy blocker?

[mallenexpensify]

Pinged @m-natarajan in Slack with the link since this is time sensitive.

[marcaaron]

Precondition: Employee made an IOU request with a tag in WS chat. Tag is disabled after that by WS admin in OD.

If there are steps required to reproduce the bug please list out exactly what actions were taken. Thanks!

[marcaaron]

I can't reproduce this on main, production or staging so I am going to guess it has been fixed. Gonna remove the blocker for now.

[m-natarajan]

@marcaaron Regression step https://expensify.testrail.io/index.php?/cases/view/2761738 is failing. I am adding a new video here.

Recording.2701.mp4

[mallenexpensify]

Thanks for the vid @m-natarajan

The disabled tag is not displayed in the list as selected

I'm unsure of the specifics but, from a common sense level, I would think this would be expected behaviour. If a tag is disabled, the user/submitter should not see that tag as an option.

[kbecciv]

There is an inconsistency between the category and tag, can someone review the issue again? Thanks

bandicam.2024-02-13.10-41-01-514.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d431d3f18048470e

[greg-schroeder]

Fair enough - I'll check back tomorrow!

[DylanDylann]

@dukenv0307's proposal looks good to me

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @cead22 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@cead22 @mallenexpensify @DylanDylann this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[greg-schroeder]

Waiting for deploy to prod

[mallenexpensify]

Deployed to product 2 days ago 🎉
Updated title to pay on 3/6

[DylanDylann]

@mallenexpensify Should we add Daily label to move forward this issue

[mallenexpensify]

Contributor: @dukenv0307 paid $500 via Upwork
Contributor+: @DylanDylann paid $500 via Upwork

Created a TestRail GH, reckon it'll be an edge case one we'll only check monthly. Thx everyone.
https://github.com/Expensify/Expensify/issues/377287