[$500] Chat - The composer jumps when editing a message

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Navigate to a chat with a lot of text messages
2. Edit the text closest to the composer

Expected Result:

It shouldn't shake or jump

Actual Result:

The composer jumps when editing a message - see this video for an example

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377229_1707770858558.YFNY4432.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ebf704e63731d68
• Upwork Job ID: 1757147558004047872
• Last Price Increase: 2024-04-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ebf704e63731d68

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

We (Applause) think this bug might be related to #vip-vsb

[jliexpensify]

@ntdiary I got assigned a similar action (i.e. shaking occurs when tapping on something) here: #34300

Do you think the root cause would be the same?

[ntdiary]

@ntdiary I got assigned a similar action (i.e. shaking occurs when tapping on something) here: #34300

Do you think the root cause would be the same?

Hi, @jliexpensify, I'm still OOO. If this is a urgent issue, please feel free to reassign another c+, or maybe I'll have 1-2 hours to dig deeper tomorrow. :)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[jliexpensify]

Than ks @ntdiary - going to reassign for now! @s77rt - please see my question here!

[s77rt]

@jliexpensify No they seem different. This one is related to the main composer getting hidden which makes the editing composer change position (jump)

[jliexpensify]

@m-natarajan you checked the ios: native box but your video seems to be iOS Safari (or another browser).

I also can't really reproduce this, @s77rt could this issue be related to how the keyboard pops up?

[s77rt]

@jliexpensify No, it's only due to the fact that we are hiding the main composer so everything shift down including the edit composer

Screen.Recording.2024-02-14.at.2.13.26.AM.mov

Before	After

[jliexpensify]

Thanks for sharing that video @s77rt - I can see it a bit more clearly now. Is it something that is a pretty simple/straightforward fix?

[s77rt]

@jliexpensify I didn't check in depth but I don't think fixing this would be straightforward.

[jliexpensify]

Cool, lets wait for some proposals then - thanks!

EDIT: posted here - https://expensify.slack.com/archives/C066HJM2CAZ/p1707880547642609

[s77rt]

Not overdue. Looking for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still looking for proposals

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jliexpensify]

Hello @sakluger - I am headed OOO from the 21st to 31st March so have assigned you as a buddy here.

Summary:

• @s77rt is still awaiting suitable proposals

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jliexpensify]

@mvtglobally can you share a video please? Thanks!

[sakluger]

Sounds like this may be fixed. Is anyone due payment? My assumption is no, @s77rt can you please confirm.

[s77rt]

@sakluger If this is fixed already then no one would be due payment

[brunovjk]

@s77rt I believe we've made significant progress in mitigating the 'shake or jump' issue by ensuring simultaneous rendering/hiding of the composer and text. I actually don't know how it was done, but it seems like that's what happened hehe.
However, a small 'shake or jump' persists due to the '2 lines' issue. I couldn't pinpoint the root cause, but it seems related to passing numberOfLines=undefined and multiline=true in the composer at ReportActionItemMessageEdit. As calculating numberOfLines upfront remains challenging, setting numberOfLines=1 has resolved the issue, but I wonder about potential regressions.
I'm questioning the use of 0 as the default value in src/components/Composer/index.tsx. Since I can't think of a scenario where 0 would be appropriate, changing it to 1 would also resolve the 'two-line composer issue'. Do you think this is worth fixing? If yes, here? Or should we create another issue?
Thank you for your time.

[s77rt]

@brunovjk If the fix will only cover the case of 2 lines then it may not be worth it as it will only sound like a workaround (issue would still be reproducible where we have multiple lines)

[brunovjk]

Update:

@s77rt please take a look #30964 (comment):
"We set the default value of numberOfLines in ReportActionItemMessageEdit composer to be undefined.
This is the same as not setting the rows property of textarea. If we don't set the rows property, textarea will have 2 rows by default."

I didn't find any related issue. I'm still working on the function to calculate numberOfLines before render the composer.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still looking for proposals. Though it has been reported that the behaviour is no longer that buggy but there is still room for improvements

[jliexpensify]

Back, thanks Sasha - unassigning you!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[brunovjk]

@s77rt what do you think about closing this current issue and opening another one? Regarding the 'Number of Lines when Editing a Message', I believe it would be cool to be similar to Slack:

2024-04-04.13-15-12.mp4

I couldn't find a solution, maybe another issue will bring the right eyes to the problem.

[s77rt]

Since the original bug does not seem to be reproducible anymore it makes sense to close this issue cc @jliexpensify

[s77rt]

@brunovjk I don't think that issue is important enough given that bug reports are limited but feel free to raise on Slack