-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU #36885
Comments
Job added to Upwork: https://www.upwork.com/jobs/~015ea497aa7819e170 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @flodnv ( |
We think that this bug might be related to #vip-bills |
Triggered auto assignment to @greg-schroeder ( |
@greg-schroeder @DylanDylann are you able to reproduce? I am unable. I think something is missing from repro steps @kbecciv ? |
I don't even get that -- @kbecciv can you share a screenshot of the expected outcome please? 😕 Pinged you on Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1708447801997469?thread_ts=1708438349.003729&cid=C01GTK53T8Q |
I've noticed a discrepancy in behavior between production and staging. In production, the avatar of a user whom I've never chatted with before, but who has an ND account, is displayed in the header. However, in staging, the user's avatar is displayed as a skeleton in both the header and LHN. Production Recording.6036.mp4Staging Recording.6035.mp4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hidden is not displayed in LHN & report header What is the root cause of that problem?When we create a money request with a new user, we have a report action is report preview action so App/src/pages/home/ReportScreen.js Line 358 in 5f84683
And after
After all above, because What changes do you think we should make in order to solve the problem?We should update
Line 530 in 29ad878
And add
What alternative solutions did you explore? (Optional)NA |
@dukenv0307 Do you suggest applying isOptimisticReport to report or reportAction? It seems your permalink taking us to success data of reportAction |
@DylanDylann I suggest to update the report data as the preview code in my proposal. The permalink is only linked to the successData. |
@DylanDylann I updated #36885, sorry for the confusion. |
@dukenv0307 Could you reproduce this issue on the latest main? |
@DylanDylann Also can't reproduce on the latest main but I found another in the latest main: Create money request in offline show skeleton instead of the grey out report. Screen.Recording.2024-02-23.at.16.40.45.mov |
@chiragsalian @flodnv we can't reproduce the original issue anymore, so I think we should remove deployBlocker label in this issue. And we also should consider to fix above bug that is mentioned by @dukenv0307 |
Sounds good, removing the blocker label and checking it off the checklist. I'd suggest to create another issue to tackle the bug that @dukenv0307 brought up. |
@chiragsalian Reported bug here. Let's close this one |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.43-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Hidden should be displayed in LHN & report header
Actual Result:
Hidden is not displayed in LHN & report header
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6385574_1708425964747.Screen_Recording_2024-02-20_at_3.44.04_at_night.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: