[$500] IOU - Description is not copied when copying IOU preview to clipboard

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.43-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to 1:1 DM.
3. Create an IOU with a description.
4. Go to IOU report.
5. Right click on the preview > Copy to clipboard.
6. Paste the content.
   Note that the description is not copied anymore

Expected Result:

The copied content will include the description, and it will be "requested $ for y".

Actual Result:

The copied content does not include the description, and it is just "requested $".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385812_1708441940728.20240220_211542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fae159a80486a6f8
• Upwork Job ID: 1759970659438272512
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fae159a80486a6f8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[paultsimura]

This looks like a regression from #36298

[flodnv]

Thanks, posted here: https://expensify.slack.com/archives/C01GTK53T8Q/p1708447230020939?thread_ts=1708444691.794139&cid=C01GTK53T8Q

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The IOU description is not copied to clipboard

What is the root cause of that problem?

This is a regression from #36298 – as @Gonals correctly noted here, we shouldn't have removed the getIOUReportActionDisplayMessage and keep using it for copy to clipboard functionality.

What changes do you think we should make in order to solve the problem?

We should partially revert the #36298 by bringing back the IOU.getIOUReportActionDisplayMessage and using it here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 362 to 370 in 2e50072

	const displayMessage = ReportUtils.getReportPreviewMessage(
	ReportUtils.getReport(ReportUtils.getOriginalReportID(reportID, reportAction)),
	reportAction,
	false,
	false,
	null,
	false,
	true,
	);

What alternative solutions did you explore? (Optional)

[DylanDylann]

@paultsimura Revert this change will re-introduce the original issue
@dukenv0307 Do you have any idea here?

[dukenv0307]

We can use the old function and remove the payerName in this function

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[flodnv]

Discussing a revert: https://expensify.slack.com/archives/C01GTK53T8Q/p1708452269749359?thread_ts=1708444691.794139&cid=C01GTK53T8Q

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Old amount is copied to clipboard when the request amount is changed

What is the root cause of that problem?

Regression as stated above

What changes do you think we should make in order to solve the problem?

1. Define new variable const isIOUTransactionAction = originalMessage?.IOUTransactionID
   and replace the check of shouldConsiderScanningReceiptOrPendingRoute with (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute) in this condition

const isIOUTransactionAction = originalMessage?.IOUTransactionID

if (!isEmptyObject(reportAction) && (isIOUTransactionAction || shouldConsiderScanningReceiptOrPendingRoute ) && reportAction && ReportActionsUtils.isMoneyRequestAction(reportAction)) {

2. Move definition of originalMessage above definition of isIOUTransactionAction
3. Add below code here

const transactionDetails = getTransactionDetails(!isEmptyObject(linkedTransaction) ? linkedTransaction : null);

4. Change [this](Localize.translateLocal('iou.requestedAmount', {formattedAmount: amountToDisplay})) code with below

Localize.translateLocal('iou.requestedAmount', {formattedAmount: amountToDisplay, comment: transactionDetails?.comment ?? ''})

What alternative solutions did you explore? (Optional)

[paultsimura]

The offending PR is being reverted now

[shahinyan11]

@paultsimura Why revert if there is working solution

[shahinyan11]

@flodnv My proposal will fix this issue and below issues
#36924
#36911

[flodnv]

Leaving this to @srikarparsi - https://expensify.slack.com/archives/C01GTK53T8Q/p1708522618781829?thread_ts=1708444691.794139&cid=C01GTK53T8Q

[srikarparsi]

Closing this out since the revert PR takes care of it and has been CPed