[Payment due][$500] Clicking on workspace description does nothing

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708458648024739

Action Performed:

1. Login to app
2. Go to workspace settings as admin
3. Click on profile
4. Add a description
5. Go wo workspace chat
6. Click on the description in the header

Expected Result:

Should open workspace description settings

Actual Result:

Nothing happening

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2760.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba64856c71c7f0c1
• Upwork Job ID: 1760144180944142336
• Last Price Increase: 2024-02-21
• Automatic offers:
• shubham1206agra | Contributor | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba64856c71c7f0c1

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[ra-md]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on workspace description does nothing

What is the root cause of that problem?

PR #36426 introduced a change where WORKSPACE_DESCRIPTION was renamed to WORKSPACE_PROFILE_DESCRIPTION.

What changes do you think we should make in order to solve the problem?

Here we can replace "WORKSPACE_DESCRIPTION" with "WORKSPACE_PROFILE_DESCRIPTION".

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Clicking on workspace description does nothing

What is the root cause of that problem?

• In here we are using ROUTES.WORKSPACE_DESCRIPTION that is undefined, so leads to the bug (See PR)

What changes do you think we should make in order to solve the problem?

• We should use WORKSPACE_PROFILE_DESCRIPTION instead.

• But, if we just fix the above, there is another bug: When we click on report description in header, the workspace description edit screen is opened. When we click on "back" button, the previous report is not opened.

• To solve that bug, we can use the backTo params, that will store the previous screen to the URL params, and based on it, we know which screen we should navigate to after clicking on back button.

What alternative solutions did you explore? (Optional)

• With the additional bug that I mentioned, we can create a new route for workspace description edit. So Once we click on the workspace description in header, only the workspace description edit modal is opened

[shubham1206agra]

@Santhosh-Sellavel is OOO. I will help out here for quick resolution.

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

@shubham1206agra I have assigned the GH to you. 🚀

[dukenv0307]

Updated alternative solution

[shubham1206agra]

@dukenv0307 Navigation seems according to behaviour. If @ra-md is unavailable right now, I will assign this to you.

cc @techievivek

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[dukenv0307]

@shubham1206agra PR #37001 is ready to review

[chiragsalian]

removing blocker label since the PR to fix the issue was CP-d and checked off the QA checklist.

[kadiealexander]

Payouts due:

• Contributor: $500 @dukenv0307
• Contributor+: $500 @shubham1206agra

Upwork job is here.

[kadiealexander]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

@shubham1206agra please complete the checklist and accept the contract, thanks!

[shubham1206agra]

@kadiealexander Can you hold my payment temporarily as per https://expensify.slack.com/archives/C02NK2DQWUX/p1710150138788529?

[kadiealexander]

Sure thing, can you complete the checklist in the meantime?

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Add workspace description #36058
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/36058/files#r1520811528
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

@kadiealexander I have discussed this internally. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

[kadiealexander]

Closing as agreed. Noting that @shubham1206agra has not been paid as per #36991 (comment)

[shubham1206agra]

@kadiealexander You can process payment here now.

[shubham1206agra]

@kadiealexander Bump here.

[shubham1206agra]

@kadiealexander Bump for the payment.

[kadiealexander]

Payouts due:

• Contributor: $500 @shubham1206agra

Upwork job is here.

[shubham1206agra]

@kadiealexander Accepted