[$500] Login - Infinite loading when login via Abracadabra page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4343102
Email or phone of affected tester (no customers): gocemate@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new tab and navigate to the staging link
4. Verify the "Abracadabra, you're logged in" page is displayed
5. Navigate to the original tab

Expected Result:

User should be logged in and there should be no long loading

Actual Result:

Infinite loading when login via Abracadabra page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394640_1709066728559.Recording__2389.mp4

View all open jobs on GitHub

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016551bee9d1747202

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[yuwenmemon]

I believe this was just due to the site slows we had just now. I'm not able to reproduce this anymore.

[lanitochka17]

Hello
This issue is stil reproducible on the latest build 1.4.46-0

Recording.2451.mp4

[yuwenmemon]

Damn you're right. Very odd - looking into this now.

[yuwenmemon]

Hmmm... I can't seem to reliably reproduce

[yuwenmemon]

I notice we don't make any calls to OpenApp when we do encounter this though

[yuwenmemon]

Okay, after some sleuthing looks like this is the PR that introduced the bug: #36852

cc @blimpich @bernhardoj @fedirjh

[yuwenmemon]

I feel like the problem is that we're calling findLastAccessedReport before any reports are loaded:

Kapture.2024-03-01.at.13.35.47.mp4

[Ollyws]

Just waiting to bump the Onyx version.

[melvin-bot]

@JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[yuwenmemon]

Heads up I'll be OOO next week so if we need another engineer to merge anything for this feel free to ping in #expensify-open-source @Ollyws

[bernhardoj]

#38114 is merged, I have raised the PR to bump it to 2.0.24

cc: @Ollyws

[Ollyws]

Onyx upgrade was deployed to production yesterday so this should be due for payment on the 29th.

[Ollyws]

Can someone take care of payment for this one? Thanks!

[JmillsExpensify]

Payment summary:

• Contributor: @bernhardoj $500
• Contributor+: @Ollyws $500

Separately, @Ollyws what are your thoughts on regression tests?

[JmillsExpensify]

Offers sent out via Upwork.

[JmillsExpensify]

Contributor contract paid.

[JmillsExpensify]

@Ollyws Quick follow-up on this question when you get a chance.

[Ollyws]

Regression Test Proposal

1. Log out of NewDot and request a new magic link
2. Navigate to email and locate the magic link - change to staging if needed
3. Open an new tab and navigate to the staging link
4. Verify the "Abracadabra, you're logged in" page is displayed
5. Navigate to the original tab
6. Verify the user is logged in succesfully

Do we agree 👍 or 👎

[Ollyws]

Requested payment in ND.

[JmillsExpensify]

Sounds good to me. I asked a colleague to confirm the payment summary before I approve payment.

[laurenreidexpensify]

Payment summary:

Contributor: @bernhardoj $500 paid via upwork
Contributor+: @Ollyws $500 paid via ND

[JmillsExpensify]

$500 approved for @Ollyws

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@JmillsExpensify, @yuwenmemon, @Ollyws, @bernhardoj, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.