[HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to Profile Settings > Wallet.
3. Tap Add bank account > Personal bank account.
4. Add any bank account.
5. Tap on the added bank account.

Expected Result:

Bank account icon is rendered without issue.

Actual Result:

Bank account icon is a green square.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b9e61412591fe6fb
• Upwork Job ID: 1762808071979184128
• Last Price Increase: 2024-02-28
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• dukenv0307 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b9e61412591fe6fb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[minorujunichi]

Contributor details
Your Expensify account email: ludwindavidnieto28@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0146b56b1bfcf3383f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[rushatgabhane]

Similar issue here - #33602

Proposal

Bank account has green square as icon instead of bank icon. In wallet page

What is the root cause of that problem?

We need to pass displayInDefaultIconColor to MenuItem.
This will remove the default fill property for icon, so it won't show a green box.

What changes do you think we should make in order to solve the problem?

Add displayInDefaultIconColor in MenuItem.

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Line 539 in dcf2e3e

<MenuItem

What alternative solutions did you explore? (Optional)

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Bank account icon is a green square

What is the root cause of that problem?

The reason for this issue is :

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 539 to 545 in dcf2e3e

	<MenuItem
	title={paymentMethod.formattedSelectedPaymentMethod.title}
	icon={paymentMethod.formattedSelectedPaymentMethod.icon}
	description={paymentMethod.formattedSelectedPaymentMethod.description}
	wrapperStyle={[styles.mb4, styles.ph5, styles.pv0]}
	interactive={false}
	/>

What changes do you think we should make in order to solve the problem?

We need to pass displayInDefaultIconColor

What alternative solutions did you explore? (Optional)

N/A

Result

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account icon is a green square.

What is the root cause of that problem?

The bank icon displays as green icon because we currently don't have displayInDefaultIconColor in the MenuItem here
. We had a similar issue earlier here.

What changes do you think we should make in order to solve the problem?

Add displayInDefaultIconColor in the MenuItem here
.

After we do this, we'll discover that the bank icon being displayed is very small.

That's because we're not setting the correct size and style of the icon like we did in the PaymentMethodList here. We need set the proper sizes and relevant style for the MenuItem here just like we did for the MenuItem in PaymentMethodList

To do this we can choose between:

1. Have a fixed style for the icon (taken from here), this might lead to discrepancy between the bank icon in PaymentMethodList and the bank icon in the bottom modal.
2. Have dynamic style for different bank icons (there're styles based on different payment methods here). This is the most consistent IMO. To make this work we need to pass the whole suite of icon properties (as in here) into the onPress here, and use it when we display the MenuItem in the bottom modal here

After the fix, it will look correctly like this:

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

Proposal updated to clarify the changes required

[abdulrahuman5196]

Checking now

[Gonals]

@dukenv0307 is the most complete one, so going with that one!

@dukenv0307, this is a deploy blocker. Do you think you could have it ready asap?

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[abdulrahuman5196]

Do let know once PR is ready

[dukenv0307]

I'll raise PR soon

[dukenv0307]

@abdulrahuman5196 The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Bank account icon is a green square #37450

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@abdulrahuman5196 Please complete BZ checklist so we can prep to issue payment

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not sure on this. Doesn't have a direct regression PR. Could be caused by some common component changes.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Wouldn't beneficial since its a UI issue and we would already have test to open this page which should be enough.

@joekaufmanexpensify Completed BZ checklist.

[joekaufmanexpensify]

TY! BZ checklist complete.

[joekaufmanexpensify]

All set to issue payment. We need to pay:

• @dukenv0307 $500 for PR. Paid via upwork.
• @abdulrahuman5196 $500 for C+. Paid via upwork.

[joekaufmanexpensify]

@dukenv0307 $500 sent and contract ended

[joekaufmanexpensify]

@abdulrahuman5196 $500 sent and contract ended

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set! thanks everyone