[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Sign in - User is not navigated to home page when authenticating with magic link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Navigate to sign in page
2. Enter email > click on 'Continue' button
3. Copy magic link > open new tab > prefix the link with 'staging' > paste to address bar > press enter
4. Switch to the tab where you are originally signing in

Expected Result:

User should be navigated to home page

Actual Result:

User remains at sign in page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402629_1709634628198.Screen_Recording_2024-03-04_at_11.56.31_at_night.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave9-collect-signup
@MitchExpensify

[arosiclair]

Reproduced in staging v1.4.47-3:

Screen.Recording.2024-03-05.at.2.34.55.PM.mov

Not reproducible in prod v1.4.46-2

[arosiclair]

I am trying to reproduce this in dev

[tgolen]

Looks like this was caused by Expensify/react-native-onyx#475 so we are going to revert that change.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mvtglobally]

Issue is only partially fixed. User has to refresh the page to login. Loading screen displayed after navigating back

Screen.Recording.2024-03-05.at.10.09.48.PM.mov

[paultsimura]

Issue is only partially fixed. User has to refresh the page to login. Loading screen displayed after navigating back

This is reproducible in Production as well, so shouldn't be a blocker. @mvtglobally could you please double-check and confirm?🙏🏼

[arosiclair]

Yes I also reproduced the loading screen in prod v1.4.46-2:

Do we already have a bug for that?

[arosiclair]

Do we already have a bug for that?

Found it: #37351

So the Onyx part of this problem was a real blocker that should be fixed now. The rest should get fixed in that issue. Closing this out!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Point to the onyx hotfix branch #37804

If no regressions arise, payment will be issued on 2024-03-13. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Point to the onyx hotfix branch #37804

If no regressions arise, payment will be issued on 2024-03-14. 🎊