[HOLD for payment 2024-03-25] [$500] Distance confirmation page shows (none) briefly when the map is loading

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Distance.
3. Enter addresses and select participants.
4. Proceed to confirmation page.

Expected Result:

The Distance row will not show (none) when the distance data is loading (production behavior).

Actual Result:

The Distance row shows (none) briefly when the distance data is loading.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6404688_1709765507166.bandicam_2024-03-07_06-48-09-918.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113e37a7ba3d78e1d
• Upwork Job ID: 1765826141463461888
• Last Price Increase: 2024-03-07

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

@cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance confirmation page shows (none) briefly when the map is loading

What is the root cause of that problem?

We display merchant as title for distance

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Lines 691 to 695 in 98129e6

	<MenuItemWithTopDescription
	key={translate('common.distance')}
	shouldShowRightIcon={!isReadOnly && canEditDistance}
	title={iouMerchant}
	description={translate('common.distance')}

So until we get the value of distance from Onyx, we try to display the title which we set as iouMerchant, but for the distance request we do not set any value and hence we see (none) for a brief period of time

What changes do you think we should make in order to solve the problem?

Change it to display the empty string if data is empty

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

This isn't a deploy blocker, the PR which made the title to iouMerchant was deployed to production 3 weeks back :)

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance confirmation page shows (none) briefly when the map is loading

What is the root cause of that problem?

There is a delay when loading the iouMerchant and while loading we show the CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT which is '(none)'

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Lines 691 to 694 in 98129e6

	<MenuItemWithTopDescription
	key={translate('common.distance')}
	shouldShowRightIcon={!isReadOnly && canEditDistance}
	title={iouMerchant}

What changes do you think we should make in order to solve the problem?

We can check if the iouMerchant is empty:

- title={iouMerchant}
+ title={isMerchantEmpty ? '' : iouMerchant}

As we have for merchant:

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Lines 709 to 714 in 98129e6

	<MenuItemWithTopDescription
	key={translate('common.merchant')}
	shouldShowRightIcon={!isReadOnly}
	title={isMerchantEmpty ? '' : iouMerchant}
	description={translate('common.merchant')}
	style={[styles.moneyRequestMenuItem]}

What alternative solutions did you explore? (Optional)

[paultsimura]

This isn't a deploy blocker, the PR which made the title to iouMerchant was deployed to production 3 weeks back

@GandalfGwaihir to prove that an issue marked as a blocker is not a blocker, please attach a recording of the same issue happening in production.

[paultsimura]

I could reproduce it neither on dev nor staging 🤔
Instead, I see "Route pending", which is expected while we're fetching the route or rate:

[cead22]

I don't think we should block deploys on this, so let's treat it as a regular bug

[cead22]

I was able to reproduce on staging wek v1.4.48-0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113e37a7ba3d78e1d

[aimane-chnaif]

Good catch!
@GandalfGwaihir I see you updated proposal 3 min after @usman-ghani564 posted.

- Change it to display the title for distance
+ Change it to display the empty string if data is empty

ProposalPolice™ 👮🏼 should be coming soon to detect these things

[allgandalf]

from my POV: I was in proceed of updating this changed and the other contributors posted in the mean time

fine with whatever the engineer decides

[cead22]

The good news is that we have plenty of open bugs and work for contributors :) and in the interest of assigning whoever posted first and being consistent with previous assignments I've done, I'm going to assign @usman-ghani564

[melvin-bot]

❌ There was an error making the offer to @aimane-chnaif for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

📣 @usman-ghani564 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[nexarvo]

@aimane-chnaif Please find the PR for this issue here: #38075

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: empty condition for distance in confirm page #38075

If no regressions arise, payment will be issued on 2024-03-25. 🎊

For reference, here are some details about the assignees on this issue:

• @usman-ghani564 requires payment (Needs manual offer from BZ)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

@usman-ghani564 Can you send me your upwork profile link, I'm having a hard time finding you.

[nexarvo]

@abekkala Please find my Upwork profile here: https://www.upwork.com/freelancers/~01b5c4ee99eace8e60

[abekkala]

PAYMENT SUMMARY FOR MAR 25

• Fix: @usman-ghani564 [$500, if no regressions] Offer
• PR Review: @aimane-chnaif [$500, if no regressions] Offer

[abekkala]

@slafortune will be handling payments for me while I'm ooo

[slafortune]

Paid 👍