-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty condition for distance in confirm page #38075
fix: empty condition for distance in confirm page #38075
Conversation
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
reviewing as I am assigned on linked issue |
@usman-ghani564 looks like you linked issue incorrectly - $ #37850
+ $ https://github.com/Expensify/App/issues/37850 |
@aimane-chnaif it's updated now |
@usman-ghani564 Tests / QA Steps is missing |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@aimane-chnaif I have added Tests and QA steps. |
|
Updated |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.53-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀
|
Details
Fixed Issues
$ #37850
PROPOSAL: #37850 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
WhatsApp.Video.2024-03-11.at.10.44.18.PM.mp4
Android: mWeb Chrome
WhatsApp.Video.2024-03-11.at.10.44.18.PM-2.mp4
iOS: Native
85266b84-cef0-47d8-831e-9692955d71c4.mp4
iOS: mWeb Safari
0ec40012-afa3-4e92-97f1-ea93202d503f.mp4
MacOS: Chrome / Safari
f1dd4c1a-709c-405e-99e7-8fb0afaeabfb.mp4
MacOS: Desktop
f970e277-538e-40c0-a9d8-bbccd3bd85dc.mp4