[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [Payment card / Subscription] Integrate “Subscription size” screen with backend data and “Subscription details” section

[MitchExpensify]

This issue covers this section of the doc https://docs.google.com/document/d/1jXV_vIsOGZuL0dMiuXDWRETAFRX64ODVAhWPtiuFXT8/edit#bookmark=id.mftmseyadzie @fabioh8010

What we are implementing here is:

• the actual API call to update subscription size
• all data on subscription size screens should come from API
• subscription size screen will be displayed in correct state for each of the mentioned conditions

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[fabioh8010]

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

[trjExpensify]

@MrMuzyk are you going to work on this now the PR for #38626 has merged?

[MrMuzyk]

@trjExpensify Yes, that will be next on my list if BE is ready. You can assign it to me already

[trjExpensify]

Perfecto!

[melvin-bot]

@MrMuzyk Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

@MrMuzyk, Can you point me to the precise section this issue covers in the Detailed, please? I'd like to update the OP accordingly

[MrMuzyk]

@MitchExpensify

This one covers BE integration of Subscription Size part. There is no section that would cover the integration part in detail, we have an overall description of how it should work - https://docs.google.com/document/d/1jXV_vIsOGZuL0dMiuXDWRETAFRX64ODVAhWPtiuFXT8/edit#bookmark=id.mftmseyadzie

What I will implement here is:

• the actual API call to update subscription size
• all data on subscription size screens should come from API
• subscription size screen will be displayed in correct state for each of the mentioned conditions

[MrMuzyk]

I'm waiting for this PR to get merged so I've opened a draft PR against it in order to get correct diff. Once the mentioned PR gets merged (hopefully soon as it's been approved by C+ already) I will make a proper PR with correct destination. Other than that it's good to review and working as expected.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[amyevans]

PR merged

[amyevans]

@mananjadhav reviewed the PR as C+ so will be due payment for that.

[joekaufmanexpensify]

Sounds good! I'm about to go OOO until 2024-06-25, but don't think payment will be due before then, so not adding an additional assignee. If anything comes up before then, please post in Slack, and someone will be able to help.

[amyevans]

Heads up that I'm out on extended leave after today. The only thing remaining here though is payment, if there are any questions feel free to ask in #wave-collect

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Subscription size backend integration #43484

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @MrMuzyk does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Subscription size backend integration #43484

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @MrMuzyk does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[joekaufmanexpensify]

We have a comprehensive set of testing steps in the design doc, so I don't think we need to add an ad-hoc test here.

[joekaufmanexpensify]

All set to issue payment later this week!

[joekaufmanexpensify]

Only payment here is $250 to @mananjadhav via NewDot for C+.

[joekaufmanexpensify]

Going to close this out for now as it's otherwise all set, but @mananjadhav you're good to request payment whenever you're ready

[JmillsExpensify]

$250 approved for @mananjadhav