Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription settings” section (UI) #38626

Closed
MitchExpensify opened this issue Mar 19, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

Complete the Implement “Subscription settings” section (UI) section of the design doc

Issue OwnerCurrent Issue Owner: @garrettmknight
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@melvin-bot melvin-bot bot added the Overdue label May 22, 2024
@amyevans amyevans added Daily KSv2 and removed Monthly KSv2 labels May 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@amyevans amyevans self-assigned this May 22, 2024
@trjExpensify
Copy link
Contributor

@fabioh8010 are you going to be working on this one? I know it has been some time since the issue was created and this message.

@melvin-bot melvin-bot bot added the Overdue label May 24, 2024
Copy link

melvin-bot bot commented May 27, 2024

@amyevans, @fabioh8010 Huh... This is 4 days overdue. Who can take care of this?

@fabioh8010
Copy link
Contributor

@trjExpensify This issue will be eventually picked up by my team, as we've started working on Subscriptions development a few days ago.

@melvin-bot melvin-bot bot removed the Overdue label May 28, 2024
@trjExpensify
Copy link
Contributor

Okay, cool.. it would be good to know who that is , so we can assign it out correctly. Thanks!

@MrMuzyk
Copy link
Contributor

MrMuzyk commented May 28, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

You can assign me :)

@amyevans amyevans assigned MrMuzyk and unassigned fabioh8010 May 28, 2024
@melvin-bot melvin-bot bot added the Overdue label May 30, 2024
@amyevans
Copy link
Contributor

@MrMuzyk was OOO yesterday/today; let us know how it's coming when you're back on Monday!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 31, 2024
@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 3, 2024

Got a draft PR open that is being checked internally at the moment. Might be moved to c+ review today

@amyevans amyevans added the NewFeature Something to build that is a new item. label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@amyevans
Copy link
Contributor

amyevans commented Jun 7, 2024

@mollfpr is C+ here so will be due payment

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Implement “Subscription settings” section (UI) [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription settings” section (UI) Jun 11, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @mollfpr requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jun 11, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription settings” section (UI) [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription settings” section (UI) Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @mollfpr requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@garrettmknight
Copy link
Contributor

Payment summary:

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Jun 20, 2024
@garrettmknight
Copy link
Contributor

Dropping to weekly for request.

Copy link

melvin-bot bot commented Jun 20, 2024

Payment Summary

Upwork Job

  • Contributor: @MrMuzyk is from an agency-contributor and not due payment
  • Reviewer: @mollfpr owed $250 via NewDot

BugZero Checklist (@garrettmknight)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@JmillsExpensify
Copy link

$250 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

8 participants